Add CameraPosition option for initializing NavigationView #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
✓ ready for review
feature
This was referenced Oct 30, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Other than this minor comment, this looks good to me. Thanks @danesfeder for running with this.
| * This method adds the {@link OnNavigationReadyCallback}, | ||
| * which will fire ready / cancel events for this view. | ||
| * | ||
| * @param onNavigationReadyCallback to be set to this view |
Contributor
There was a problem hiding this comment.
Minor detail - Could we add the missing Javadoc @param CameraPosition?
danesfeder
force-pushed
the
dan-starting-point
branch
from
c163341 to
1e72ff9
Compare
Contributor
Author
|
@Guardiola31337 good catch, this is updated |
danesfeder
force-pushed
the
dan-starting-point
branch
from
1e72ff9 to
b81251a
Compare
danesfeder
force-pushed
the
dan-starting-point
branch
from
b81251a to
66c1466
Compare
Guardiola31337
approved these changes
Oct 31, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @danesfeder 
danesfeder
removed
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1245
We currently don't offer a way to start up the
NavigationViewwith a camera position. Our UX isn't ideal, zooming in from0, 0world view.This PR adds a new
NavigationView#initialize(OnNavigationReadyCallback, CameraPosition)that will set theMapboxMapto that position as soon as it's ready.In the
EmbeddedNavigationActivity, we went from this:to this:
And also added the option in
NavigationLauncherOptions:cc @tobrun