remove unnecessary force first location update from route (origin) (#1488)

Author: Guardiola31337

libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationLocationEngineUpdater.java

@@ -1,15 +1,10 @@
 package com.mapbox.services.android.navigation.v5.navigation;
 
-import android.location.Location;
-
 import com.mapbox.android.core.location.LocationEngine;
-import com.mapbox.api.directions.v5.models.DirectionsRoute;
-import com.mapbox.services.android.navigation.v5.utils.RouteUtils;
 
 class NavigationLocationEngineUpdater {
 
   private final NavigationLocationEngineListener listener;
-  private RouteUtils routeUtils;
   private LocationEngine locationEngine;
 
   NavigationLocationEngineUpdater(LocationEngine locationEngine, NavigationLocationEngineListener listener) {
@@ -24,24 +19,7 @@ void updateLocationEngine(LocationEngine locationEngine) {
     locationEngine.addLocationEngineListener(listener);
   }
 
-  @SuppressWarnings("MissingPermission")
-  void forceLocationUpdate(DirectionsRoute route) {
-    Location location = locationEngine.getLastLocation();
-    if (!listener.isValidLocationUpdate(location)) {
-      routeUtils = obtainRouteUtils();
-      location = routeUtils.createFirstLocationFromRoute(route);
-    }
-    listener.onLocationChanged(location);
-  }
-
   void removeLocationEngineListener() {
     locationEngine.removeLocationEngineListener(listener);
   }
-
-  private RouteUtils obtainRouteUtils() {
-    if (routeUtils == null) {
-      return new RouteUtils();
-    }
-    return routeUtils;
-  }
 }

libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationService.java

@@ -65,7 +65,6 @@ public void onDestroy() {
   void startNavigation(MapboxNavigation mapboxNavigation) {
     initialize(mapboxNavigation);
     startForegroundNotification(notificationProvider.retrieveNotification());
-    locationUpdater.forceLocationUpdate(mapboxNavigation.getRoute());
   }
 
   /**

libandroid-navigation/src/test/java/com/mapbox/services/android/navigation/v5/navigation/NavigationLocationEngineUpdaterTest.java

@@ -1,17 +1,12 @@
 package com.mapbox.services.android.navigation.v5.navigation;
 
-import android.location.Location;
-
 import com.mapbox.android.core.location.LocationEngine;
-import com.mapbox.api.directions.v5.models.DirectionsRoute;
 
 import org.junit.Test;
 
-import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
 
 public class NavigationLocationEngineUpdaterTest {
 
@@ -49,19 +44,6 @@ public void updateLocationEngine_oldEngineListenerIsRemoved() {
     verify(locationEngine).removeLocationEngineListener(eq(listener));
   }
 
-  @Test
-  public void forceLocationUpdate_nonNullLastLocationIsSent() {
-    LocationEngine locationEngine = mock(LocationEngine.class);
-    when(locationEngine.getLastLocation()).thenReturn(mock(Location.class));
-    NavigationLocationEngineListener listener = mock(NavigationLocationEngineListener.class);
-    when(listener.isValidLocationUpdate(any(Location.class))).thenReturn(true);
-    NavigationLocationEngineUpdater provider = new NavigationLocationEngineUpdater(locationEngine, listener);
-
-    provider.forceLocationUpdate(mock(DirectionsRoute.class));
-
-    verify(listener).onLocationChanged(any(Location.class));
-  }
-
   @Test
   public void removeLocationEngineListener() {
     LocationEngine locationEngine = mock(LocationEngine.class);