Skip to content

Commit 20a59cb

Browse files
author
Devota Aabel
committed
Added magic numbers
1 parent d28ba0b commit 20a59cb

File tree

1 file changed

+6
-3
lines changed
  • libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction

1 file changed

+6
-3
lines changed

libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/ExitSignCreator.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ class ExitSignCreator extends NodeCreator<BannerComponentNode, ExitSignVerifier>
1515
private int startIndex;
1616
private TextViewUtils textViewUtils;
1717
private String modifier;
18+
private final String EXIT = "exit";
19+
private final String EXIT_NUMBER = "exit-number";
20+
private final String LEFT = "left";
1821

1922
ExitSignCreator() {
2023
super(new ExitSignVerifier());
@@ -24,9 +27,9 @@ class ExitSignCreator extends NodeCreator<BannerComponentNode, ExitSignVerifier>
2427
@Override
2528
BannerComponentNode setupNode(BannerComponents components, int index, int startIndex, String
2629
modifier) {
27-
if (components.type().equals("exit")) {
30+
if (components.type().equals(EXIT)) {
2831
return null;
29-
} else if (components.type().equals("exit-number")) {
32+
} else if (components.type().equals(EXIT_NUMBER)) {
3033
exitNumber = components.text();
3134
this.startIndex = startIndex;
3235
this.modifier = modifier;
@@ -52,7 +55,7 @@ void postProcess(TextView textView, List<BannerComponentNode> bannerComponentNod
5255

5356
TextView exitSignView;
5457

55-
if (modifier.equals("left")) {
58+
if (modifier.equals(LEFT)) {
5659
exitSignView = (TextView) inflater.inflate(R.layout.exit_sign_view_left, root, false);
5760
} else {
5861
exitSignView = (TextView) inflater.inflate(R.layout.exit_sign_view_right, root, false);

0 commit comments

Comments
 (0)