Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Convert MGLCustomStyleLayerAdditions into a class #5972

Closed
1ec5 opened this issue Aug 12, 2016 · 1 comment
Closed

Convert MGLCustomStyleLayerAdditions into a class #5972

1ec5 opened this issue Aug 12, 2016 · 1 comment
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS refactor
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2016

Now that we have a formal concept of style layers in the iOS and macOS SDKs, we should convert the MGLCustomStyleLayerAdditions category methods on MGLMapView into a proper subclass of MGLStyleLayer. We can continue to leave this class undocumented, signaling that it’s subject to change and not intended for casual use. Depending on how things shake out, it might end up being easier to extend support for macOS than to exclude macOS from the new implementation.

/cc @frederoni @friedbunny @incanus
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor labels Aug 12, 2016
@1ec5 1ec5 modified the milestone: ios-v3.4.0 Aug 12, 2016
@1ec5 1ec5 mentioned this issue Aug 12, 2016
Closed
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Nov 30, 2016
@1ec5 1ec5 mentioned this issue Nov 30, 2016
Merged
2 tasks
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 7, 2016

Fixed in #7250 on the v3.4.0 release branch.

@1ec5 1ec5 closed this as completed Dec 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
1 participant
@1ec5