Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal map (normal) layer type #4790

Closed
wants to merge 1 commit into from
Closed

Normal map (normal) layer type #4790

wants to merge 1 commit into from

Conversation

ibesora
Copy link

@ibesora ibesora commented Jun 6, 2017

Adds a new layer type called normal that given a source layer with raster type pointing to a normal map pyramid, is shaded with the light defined on the style object.

I've created a new draw_normal.js where the webgl initialization is done and two files: normal.fragment.js and normal.vertex.js with the normal mapping shader. The remaining files are modified to update the spec to support the new type and its parameters (the same as a raster layer)

@jfirebaugh jfirebaugh requested a review from anandthakker June 6, 2017 18:24
@mourner
Copy link
Member

mourner commented Jun 6, 2017

Is this similar to #4701 @kkaefer @mollymerp?

@anandthakker
Copy link
Contributor

@ibesora thank you very much for submitting this PR!

As @mourner notes above, we are working on similar (but not identical) functionality over in #4701, with the hillshade layer type.

With that new type already being added to the spec, I think that the normal layer you've created here would be fit better as a custom layer. The custom layer API is still in early design/development, but I think this is a great use case for us to take into account while working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants