Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type='button' to Fullscreen button #4397

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Add type='button' to Fullscreen button #4397

merged 1 commit into from
Mar 10, 2017

Conversation

karlguillotte
Copy link
Contributor

@karlguillotte karlguillotte commented Mar 9, 2017 •
edited
Loading

Prevent Fullscreen control's button from acting like form submit buttons.

Similar to #2934, #2935

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@karlguillotte
Add type='button' to Fullscreen button
9a9b0f2 
Prevent Fullscreen control's button from acting like form submit buttons. 

Similar to #2934, #2935
@mollymerp
Copy link
Contributor

Thank you @karlguillotte!

cc @colleenmcginnis

lucaswoj
lucaswoj approved these changes Mar 9, 2017
View reviewed changes
Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 😄

@mollymerp mollymerp merged commit adef501 into mapbox:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswoj lucaswoj lucaswoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlguillotte @mollymerp @lucaswoj