Optimize layer update #3853
Merged
Optimize layer update #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswoj
approved these changes
Dec 22, 2016
jfirebaugh
approved these changes
Dec 22, 2016
|
it may cause new bugs for applications using the 'setStyle' method. it won't refresh sprite any more |
|
@zuo1188 if you're experiencing a specific issue, please submit it as a new issue to GitHub (with clear steps to reproduce and a minimal test case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the worker avoid recreating all layer instances when updating just a few layers (e.g. with
setFilter).This fixes performance for cases where the updated source doesn't contain much data, but the update is bogged down by all other layers from the basemap — e.g. as on our official hover example. Ref #2874 (comments).
cc @jfirebaugh @lucaswoj