Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map#setFeatureState should reject feature identifier without an id field #6959

Closed
asheemmamoowala opened this issue Jul 12, 2018 · 1 comment
Closed

Map#setFeatureState should reject feature identifier without an id field #6959

asheemmamoowala opened this issue Jul 12, 2018 · 1 comment
Assignees
@asheemmamoowala
Labels
api 📝

Comments

@asheemmamoowala
Copy link
Contributor

The Map#setFeatureState should require the id field in the first argument and reject invocations missing said field.

mapbox-gl-js version: 0.46.1

Discovered this while debugging an issue where string ids in geojson data do not work with Map#setFeatureState. That is related to : #2716.
@asheemmamoowala asheemmamoowala self-assigned this Jul 12, 2018
@asheemmamoowala asheemmamoowala mentioned this issue Jul 12, 2018
Merged
@asheemmamoowala asheemmamoowala changed the title Map#setFeatureState should reject feature identifier with an id field Map#setFeatureState should reject feature identifier without an id field Jul 16, 2018
@asheemmamoowala
Copy link
Contributor Author

Addressed by #6974

@bfrengley bfrengley mentioned this issue Aug 14, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asheemmamoowala asheemmamoowala

Labels
api 📝
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @asheemmamoowala