Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flyTo does not check the value of transform.renderWorldCopies #4449

Closed
CrokinoleMaster opened this issue Mar 18, 2017 · 2 comments
Closed

flyTo does not check the value of transform.renderWorldCopies #4449

CrokinoleMaster opened this issue Mar 18, 2017 · 2 comments

Comments

@CrokinoleMaster
Copy link
Contributor

mapbox-gl-js version: v0.34.0

Steps to Trigger Behavior

  1. initialize a map and set option.renderWorldCopies = false
  2. try to do a flyTo where Math.abs(tr.center.lng) + Math.abs(center.lng) > 180

Expected Behavior

flyTo should stay in the noncopied world where -180 < lat < 180.

Actual Behavior

flyTo will to to bring you to a worldCopy which is not rendered.

Something like this will fix the problem.
CrokinoleMaster@4baab4a
@CrokinoleMaster CrokinoleMaster mentioned this issue Mar 18, 2017
Merged
@andrewharvey
Copy link
Collaborator

@huaruiwu I encourage you to submit this is a PR. Your fix looks good to me!

@CrokinoleMaster CrokinoleMaster mentioned this issue Mar 20, 2017
Merged
3 tasks
@andrewharvey
Copy link
Collaborator

Fixed in 9941dde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfirebaugh @andrewharvey @CrokinoleMaster