You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several constants and calculations in draw_symbol.js and the symbol_sdf shaders that are difficult to interpret / understand. I'm pretty much with @lucaswoj when he says:
I prefer a very clear constant name (ideally googleable) to a magic number, and a magic number to a cryptic constant name.
(though I'd say a semi-clear constant name with a one-line comment to explain it still beats a magic number in my book)
The text was updated successfully, but these errors were encountered:
blurOffset (now inlined as 6.0 in the frag shader)
buff (was u_buffer) (btw, is it a coincidence that 6/8 (present in calculation for the halo version of this value) = 0.75 = (265 - 64)/256 (the non-halo version of this value)?)
There are several constants and calculations in
draw_symbol.js
and thesymbol_sdf
shaders that are difficult to interpret / understand. I'm pretty much with @lucaswoj when he says:(though I'd say a semi-clear constant name with a one-line comment to explain it still beats a magic number in my book)
The text was updated successfully, but these errors were encountered: