Skip to content

Add the ability to control the clock in integration tests #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucaswoj opened this issue Jan 13, 2017 · 1 comment
Closed

Add the ability to control the clock in integration tests #3966

lucaswoj opened this issue Jan 13, 2017 · 1 comment
Assignees

Comments

@lucaswoj
Copy link
Contributor

ref #3912

@ChrisLoer
Copy link
Contributor

On top of allowing us to add tests for transitions and other animations, this is important for making the test suite run quickly.

In the current code, ongoing animations don't set the _styleDirty flag until after the render and loaded events have already fired, which incorrectly makes the map appear to be fully loaded when it hasn't actually reached steady state. Fixing the ordering in that code makes the test suite take at least four times longer to run.

/cc @anandthakker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants