-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm behavior of symbol-placement: point and LineStrings #3808
Comments
This behaviour has not been explicitly specified or tested until recently. Consistency between symbol placement and circle placement is desirable. This would be most easily acheived by adding a new |
I agree that this extends to Can you say more about what the behavior of |
Quick table to clarify my point about centroids:
To get the placement of circles to match the placement of symbols in point placement mode, we'd need to replace the "placed at centroid" behaviour with "placed at every vertex" behaviour. I'd advocate for keeping the "placed at centroid" behaviour available under a |
@lucaswoj an alternative suggestion from me is to have
I think this is more intuitive and generally more useful. For the previous behavior, I'd expect people to use different geometry types (e.g. multipoint). |
By centroid, do you mean "pole of inaccessibility"? My proposal would be either of these two:
or
|
Yup. I've been incorrectly using the term centroid. ("pole of inaccessibility" is so long and "POI" is so overloaded 😬)
Those both look good. @ansis Do you remember the motivation behind #2027? Curious if there are any important use cases for the current circle behaviour. |
Currently, a symbol layer using
symbol-placement: point
renders a symbol for only the first coordinate pair in a LineString (see e.g. this test case).Is this the intended behavior? It would seem more logical to render a symbol for each point in the LineString (or MultiLineString).
The text was updated successfully, but these errors were encountered: