-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor source interface to better accommodate non-tiled sources #3186
Labels
Comments
This was referenced Sep 14, 2016
@lucaswoj why does |
@mourner Typo. Fixed above. |
This is also being tracked for the iOS and macOS SDKs in mapbox/mapbox-gl-native#6861, happening in mapbox/mapbox-gl-native#6940. |
This refactor should also accommodate non-tiled vector sources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently shoehorn all source types into the
VectorTileSource
interface by abusingTile
objects. For example,ImageSource
populates a singleTile
with a number of ad-hoc properties. This architecture breaks and causes bugs like #3010.There are several different types of sources in GL JS and each should have its own interface:
Wiring up these interfaces to
StyleLayers
,SourceCache
, etc will require some elbow grease and will be worth it. 💪 Note the elimination ofTile
objects per #145.Inspired by #3010 (comment)
Related to #2982 #281 #3010 #3123
The text was updated successfully, but these errors were encountered: