-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "SourceCache" #2291
Comments
I think we should wholly revert the relationship inversion between |
@jfirebaugh can you say more about this? I agree that the current coupling is not ideal, but it's not clear to me that inverting the dependencies would really eliminate it. Would another way to improve this might be to clarify and simplify the Source interface? |
Closing as too vague — we should create new issues for any specific things we can improve. |
The
SourceCache
class could use a big refactor (maybe even a ground-up rewrite) toref #2287
The text was updated successfully, but these errors were encountered: