Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to feature-filter 2.0 #2024

Closed
mourner opened this issue Jan 29, 2016 · 4 comments
Closed

Upgrade to feature-filter 2.0 #2024

mourner opened this issue Jan 29, 2016 · 4 comments
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@mourner
Copy link
Member

mourner commented Jan 29, 2016

It comes with major improvements:

  • major performance boost for big in filters (with thousands of items) — up to 100 times faster
  • fixed error that prevented in filters go beyond 64k items
  • 40% faster filter creation
@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Jan 29, 2016
@mourner mourner closed this as completed in 4a9f8ca Feb 5, 2016
@fnicollet
Copy link
Contributor

Hello @mourner

Should it speed up rendering significantly? I can't see any changes, apart from a few regressions that might not be related to this changes

Thanks,
Fabien

@mourner
Copy link
Member Author

mourner commented Feb 9, 2016

@fnicollet it doesn't affect rendering. It slightly reduces tile "loading" times (only noticeable if you use very complicated styles).

@mourner
Copy link
Member Author

mourner commented Feb 11, 2016

@fnicollet here's a cool example that benefits from the improved filter performance: https://www.mapbox.com/mapbox-gl-js/example/using-featuresin/

@fnicollet
Copy link
Contributor

ok, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

2 participants