Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an example for fullscreen mode #1824

Closed
lucaswoj opened this issue Dec 10, 2015 · 12 comments
Closed

Create an example for fullscreen mode #1824

lucaswoj opened this issue Dec 10, 2015 · 12 comments
Assignees

Comments

@lucaswoj
Copy link
Contributor

mapbox.js has such an example

ref #1821 (comment)

cc @jingsam

@josiekre
Copy link

+1

@dshakya
Copy link

dshakya commented Oct 4, 2016

Is the team working on implementing Fullscreen plugin for MapboxGL? Missing this feature big time.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Oct 4, 2016

@dshakya While there is no pre-built plugin, you should be able to implement this feature downstream:

map.getCanvas().webkitRequestFullScreen(); // there are a few other vendor prefixes to try
map.resize();

@colleenmcginnis
Copy link
Contributor

@lucaswoj I was thinking of working on this example. Do you think we should build a control or just show users how to implement what you suggested above?

@dshakya
Copy link

dshakya commented Oct 5, 2016

Would be lovely if you could build a control like the one for Leaflet

@dshakya
Copy link

dshakya commented Oct 25, 2016

Hi @colleenmcginnis, would you know if anyone is working on this feature? Or any directions on how would I go about implementing it?

@karlguillotte
Copy link
Contributor

@lucaswoj I created that fullscreen control. Would you be interested in a PR?

@andrewharvey
Copy link
Collaborator

andrewharvey commented Dec 12, 2016

@karlguillotte Not sure if you saw this one by @colleenmcginnis to compare?

@karlguillotte
Copy link
Contributor

Thanks @andrewharvey ! I have not seen that one yet.

@shotor
Copy link

shotor commented Jan 2, 2017

I tried this, but my controls disappear in fullscreen mode.

Doesn't work on JsFiddle, so here's a gist: https://gist.github.com/shotor/316d2dc8b07fb69b6b73e4589b07b6ce

Has anyone been able to get the controls to display in full screen?

@anx-ckreuzberger
Copy link

Any chance the fullscreen stuff from this commit can make it into the master? Is there a PR or something?
Pinging @colleenmcginnis on this too

@mollymerp
Copy link
Contributor

this has shipped in #3977 !! will be available in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants