Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

mapbox-gl dependency is stuck at 0.44.1 - can we have an update to keep it in line? #33

Closed
mwarren2 opened this issue Nov 19, 2018 · 1 comment

Comments

@mwarren2
Copy link

mwarren2 commented Nov 19, 2018

I forked this module to see if an update to mapbox-gl version 0.51.0 might be feasible (it's currently 0.44.1 in package.json).

This would be good because 0.51.0 fixes a problem between mapbox-gl and jsdom which also crops up when testing with mapbox-gl-js-mock.

Two issues emerged with my attempted update to 0.51.0 and I didn't go further so there may be more.
For example:

TypeError: Evented is not a constructor
at new Map (node_modules/mapbox-gl-js-mock/classes/map.js:53:19)

This is because /src/util/evented.js from mapbox-gl originally exported just one object with:
module.exports = Evented;

now it exports three separate classes, one of which is called Evented.
If you fix that, it fails again with a similar problem on another class (LatLng).

An update to keep up with mapbox-gl would be much appreciated. Thanks

@mwarren2 mwarren2 changed the title mapbox-gl dependency is stuck at 0.44.1 - can we have an update please? mapbox-gl dependency is stuck at 0.44.1 - can we have an update to keep it in line? Nov 19, 2018
@fc fc mentioned this issue Nov 19, 2018
@mwarren2
Copy link
Author

Closed because by now the mock is out of date

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@mwarren2 and others