Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map box draw prevents disabling of zoom on double click #710

Closed
IAfanasov opened this issue Nov 11, 2017 · 2 comments
Closed

Map box draw prevents disabling of zoom on double click #710

IAfanasov opened this issue Nov 11, 2017 · 2 comments

Comments

@IAfanasov
Copy link

Have a look in files below and you will easily find a problem: double click zoom firstly disabled and then enabled no matter if it was disabled before.

https://github.com/mapbox/mapbox-gl-draw/blob/066ab202a2132bb9c725607ad588f7068972b298/src/modes/simple_select.js
https://github.com/mapbox/mapbox-gl-draw/blob/066ab202a2132bb9c725607ad588f7068972b298/src/modes/simple_select.js
https://github.com/mapbox/mapbox-gl-draw/blob/c14acde0af91c236e4d67ac9ddb69df11c063fc2/src/modes/draw_line_string.js

mapbox-gl-js version: v0.39.1
mapbox-gl-draw version: v1.0.2

Steps to Trigger Behavior

  1. initialise map and call map.doubleClickZoom.disable();
  2. double click on map

Expected Behavior

map is not zoomed

Actual Behavior

map is zoomed

@mcwhittemore
Copy link
Contributor

Will be fixed by #696

@mcwhittemore
Copy link
Contributor

This has been fixed and is in 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants