Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensible URL query items #343

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Extensible URL query items #343

merged 1 commit into from
Feb 9, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Feb 9, 2019

Renamed DirectionsOptions.params to urlQueryItems and made it open so that subclasses of RouteOptions and MatchOptions can add any additional URL query parameters that are supported by the Mapbox Directions and Map Matching APIs.

Fixes #339.

/cc @mapbox/navigation-ios @taraniduncan

@1ec5 1ec5 added the improvement Improvement for an existing feature. label Feb 9, 2019
@1ec5 1ec5 self-assigned this Feb 9, 2019
@1ec5 1ec5 requested a review from JThramer February 9, 2019 00:04
JThramer
JThramer approved these changes Feb 9, 2019
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👐

@1ec5 1ec5 merged commit 5090406 into master Feb 9, 2019
@1ec5 1ec5 deleted the 1ec5-open-inquery-339 branch February 9, 2019 00:08
@1ec5 1ec5 mentioned this pull request Sep 15, 2020
Closed
@1ec5 1ec5 mentioned this pull request Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

Assignees

@1ec5 1ec5

Labels
improvement Improvement for an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @JThramer