Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review required fields and types #122

Open
kamicut opened this issue Aug 2, 2017 · 1 comment
Open

Review required fields and types #122

kamicut opened this issue Aug 2, 2017 · 1 comment
Labels

Comments

@kamicut
Copy link
Contributor

kamicut commented Aug 2, 2017

We have received feedback that:

  • some fields that are non-required are triggering as required and preventing form submission
  • some fields are triggering type errors (e.g number of beneficiaries is asking for a number even though a number is entered)
  • draft mode sometimes doesn't work when omitting required fields

We should go over the fields and make sure there aren't any inconsistencies in field requirements
cc @sethvincent @felskia

@kamicut kamicut added the bug label Aug 2, 2017
@kamicut
Copy link
Contributor Author

kamicut commented Aug 18, 2017

I think these are fixed with #124

We could go over all the combination of fields but I think that doesn't scale. We could figure out a minimal test suite that can cover some of the expected behavior. It could be a small or a huge lift but I don't have experience with browser form testing. What do you think @sethvincent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant