Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Built-in Support for Model Stacking #520

Merged
merged 17 commits into from
Dec 17, 2024

Conversation

taimo3810
Copy link
Contributor

@taimo3810 taimo3810 commented Dec 10, 2024

ISSUE
#519

TODO

  • Implement model, backbone and config class for stacking
  • write tests
  • minor refactoring
  • check if all tests are passed (local)
  • write documentation
  • fix pytest error on python 3.8

📚 Documentation preview 📚: https://pytorch-tabular--520.org.readthedocs.build/en/520/

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 10, 2024
@taimo3810 taimo3810 marked this pull request as draft December 10, 2024 15:05
@dosubot dosubot bot added the enhancement New feature or request label Dec 10, 2024
@taimo3810 taimo3810 marked this pull request as ready for review December 11, 2024 11:27
@taimo3810 taimo3810 marked this pull request as draft December 11, 2024 12:04
@taimo3810 taimo3810 marked this pull request as ready for review December 11, 2024 13:16
taimo added 5 commits December 12, 2024 00:13
- Updated API documentation to include `StackingModelConfig` and `StackingModel`.
- Added a new tutorial notebook demonstrating model stacking in PyTorch Tabular, covering setup, configuration, training, and evaluation.
- Enhanced existing documentation to explain the model stacking concept and its benefits.

This commit improves the usability and understanding of the stacking functionality in the library.
…tion

This commit removes the GatedAdditiveTreeEnsembleConfig lambda function from the get_model_configs function in the test_model_stacking.py file, streamlining the model configuration process. This change enhances code clarity and focuses on the relevant model configurations for stacking.
- Added a new entry for "Model Stacking" in the navigation structure.
- Included a link to the tutorial notebook "tutorials/16-Model Stacking.ipynb" for users to learn about model stacking.

This change enhances the documentation by providing users with direct access to resources related to model stacking.
- Removed unnecessary indentation for the "Model Stacking" entry in the navigation.
- Maintained the link to the tutorial notebook "tutorials/16-Model Stacking.ipynb" for user access.

This change improves the clarity of the documentation structure without altering the content.
- Changed the type annotation of model_configs from list[ModelConfig] to list
@taimo3810
Copy link
Contributor Author

taimo3810 commented Dec 13, 2024

@manujosephv
I fixed the error caused by pytest on Python 3.8. Could you rerun pytest?

@taimo3810
Copy link
Contributor Author

taimo3810 commented Dec 14, 2024

@manujosephv
I fixed some parts of the code again. Sorry, could you rerun pytest?

@taimo3810
Copy link
Contributor Author

taimo3810 commented Dec 14, 2024

@manujosephv
I rewrite some parts in my code again. Could you rerun pytest?

@manujosephv
Copy link
Owner

@taimo3810 Would you be able to run pytest locally before pushing? might be easier and quicker. I've approved the run this time,

@taimo3810
Copy link
Contributor Author

@manujosephv
Thank you for pointing that out. You're right—I should have run pytest locally before pushing.
I’m sorry for the inconvenience caused. I’ll make sure to thoroughly check everything locally next.
I really appreciate you approving the run this time!

@manujosephv manujosephv merged commit e042201 into manujosephv:main Dec 17, 2024
9 checks passed
@manujosephv
Copy link
Owner

Thanks for this great PR @taimo3810 . I love that you also added documentation and tutorials 😄 . Merging it!

@taimo3810 taimo3810 deleted the model_stacking branch December 17, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants