-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot importing using Node.js native ESM #271
Comments
@manuelbieh another approach would be to release a breaking change that drops CommonJS altogether. That would be my recommendation! Many packages are moving to this since all current versions of Node.js supports ESM now 🚀 You can read about Sindres approach (which I, and many other maintainers are also using) here: sindresorhus/meta#15 |
It is as simple as:
tsconfig.json: {
"compilerOptions": {
"target": "es2017",
"lib": [
"es2018",
"dom"
],
"outDir": "dist/tsc",
"rootDir": "src/",
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": false,
"declaration": true,
"declarationDir": "dist/types",
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"strictNullChecks": true
},
"include": [
"src/**/*.ts",
"src/**/*.d.ts"
],
"exclude": [
"node_modules",
"**/*.test.ts"
]
} |
Some update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to import this library with the native support for ESM that's available in Node.js 12, 14, and 16 I'm running into the following problem:
According to the readme it seems like this should work:
I think that the problem is that the package.json is missing the
exports
key which describes how the module should be loaded by the native Node.js ESM.This is documented here: https://nodejs.org/api/packages.html#packages_package_entry_points
Basically, I think that something like this should be added:
I will try this and submit a PR if it works 🚀
The text was updated successfully, but these errors were encountered: