Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI's endopoint-specific classes #10

Open
miltondp opened this issue Mar 15, 2023 · 1 comment
Open

Add OpenAI's endopoint-specific classes #10

miltondp opened this issue Mar 15, 2023 · 1 comment

Comments

@miltondp
Copy link
Collaborator

The current class that handles connections to the OpenAI API (GPT3CompletionModel) has too many responsibilities: it handles connections to the Completion and Edits endpoints, and PR #9 adds the ChatCompletion endpoints as well.

We should have classes that are endpoint-specific (such as CompletionModel, EditsModel or ChatCompletionModel), instead of model family specific (GPT3CompletionModel).

@castedo
Copy link

castedo commented Sep 6, 2024

#51 might be useful here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants