From 284d037b9322d5ac7aae54027524dbd78a10ef02 Mon Sep 17 00:00:00 2001 From: ethan Date: Tue, 27 Jun 2023 13:56:47 +0800 Subject: [PATCH 1/2] add zero address check on oracle.sol --- l2geth/contracts/checkpointoracle/contract/oracle.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/l2geth/contracts/checkpointoracle/contract/oracle.sol b/l2geth/contracts/checkpointoracle/contract/oracle.sol index 010644727..ae567b42f 100644 --- a/l2geth/contracts/checkpointoracle/contract/oracle.sol +++ b/l2geth/contracts/checkpointoracle/contract/oracle.sol @@ -18,6 +18,7 @@ contract CheckpointOracle { */ constructor(address[] memory _adminlist, uint _sectionSize, uint _processConfirms, uint _threshold) public { for (uint i = 0; i < _adminlist.length; i++) { + require(_adminlist[i] != address(0),"admin list cant contains 0 address"); admins[_adminlist[i]] = true; adminList.push(_adminlist[i]); } From eda269e30a002ef013f21fc64271a67756cdbfb5 Mon Sep 17 00:00:00 2001 From: ethan Date: Tue, 27 Jun 2023 15:24:09 +0800 Subject: [PATCH 2/2] fix comments --- l2geth/contracts/checkpointoracle/contract/oracle.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l2geth/contracts/checkpointoracle/contract/oracle.sol b/l2geth/contracts/checkpointoracle/contract/oracle.sol index ae567b42f..a58f8abc7 100644 --- a/l2geth/contracts/checkpointoracle/contract/oracle.sol +++ b/l2geth/contracts/checkpointoracle/contract/oracle.sol @@ -18,7 +18,7 @@ contract CheckpointOracle { */ constructor(address[] memory _adminlist, uint _sectionSize, uint _processConfirms, uint _threshold) public { for (uint i = 0; i < _adminlist.length; i++) { - require(_adminlist[i] != address(0),"admin list cant contains 0 address"); + require(_adminlist[i] != address(0),"admin list can't contain 0 address"); admins[_adminlist[i]] = true; adminList.push(_adminlist[i]); }