Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to compile with -DWITH_JIEBA=0 #2877

Open
5 tasks
akostadinov opened this issue Dec 21, 2024 · 0 comments
Open
5 tasks

fails to compile with -DWITH_JIEBA=0 #2877

akostadinov opened this issue Dec 21, 2024 · 0 comments
Labels

Comments

@akostadinov
Copy link

Bug Description:

Build manticore with -DWITH_JIEBA=0. Without this options it does compile. Not a huge issue but decided to report it.

/tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/sphinx.cpp: In static member function 'static std::pair<unsigned int, unsigned int> CSphIndex_VLN::CreateRowMapsAndCountTotalDocs(const CSphIndex_VLN*, const CSphIndex_VLN*, CSphFixedVector<unsigned int>&, CSphFixedVector<unsigned int>&, const ISphFilter*, bool, MergeCb_c&)':
/tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/sphinx.cpp:6679:32: warning: comparison of integer expressions of different signedness: 'RowID_t' {aka 'unsigned int'} and 'int' [-Wsign-compare]
 6679 |         for ( RowID_t i = 0; i < dDstRowMap.GetLength(); ++i, pRow+=iStride )
      |                              ~~^~~~~~~~~~~~~~~~~~~~~~~~
/tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/sphinx.cpp: In member function 'CSphIndex_VLN::LOAD_E CSphIndex_VLN::LoadHeaderJson(const CSphString&, bool, CSphEmbeddedFiles&, FilenameBuilder_i*, CSphString&)':
/tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/sphinx.cpp:8858:95: error: invalid initialization of reference of type 'CSphString&' from expression of type 'FilenameBuilder_i*'
 8858 |         if ( !SpawnFilterJieba ( pFieldFilter, m_tSettings, tTokSettings, sHeaderName.cstr(), pFilenameBuilder, m_sLastError ) )
      |                                                                                               ^~~~~~~~~~~~~~~~
In file included from /tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/sphinx.cpp:29:
/tmp/manticore_uselessly_very_long_path_to_prevent_rpm_build_issues/src/jieba.h:37:31: note: in passing argument 5 of 'bool SpawnFilterJieba(std::unique_ptr<ISphFieldFilter>&, const CSphIndexSettings&, const CSphTokenizerSettings&, const char*, CSphString&)'
   37 |                 const char *, CSphString & )
      |                               ^~~~~~~~~~~~
gmake[2]: *** [src/CMakeFiles/lmanticore.dir/build.make:113: src/CMakeFiles/lmanticore.dir/sphinx.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:308: src/CMakeFiles/lmanticore.dir/all] Error 2
gmake: *** [Makefile:156: all] Error 2

You can see a Dockerfile for reproduce here: https://github.com/3scale/searchd/blob/fc181830fba63f4e18414f0d07d258fab176cccc/Containerfile

The build result is here: https://github.com/3scale/searchd/actions/runs/12440151183/job/34735119023?pr=17

Manticore Search Version:

6.3.8

Operating System Version:

CnetOS Stream 9

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant