Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax to specify options for right joined table #2803

Open
5 tasks done
glookka opened this issue Nov 30, 2024 · 2 comments
Open
5 tasks done

Add syntax to specify options for right joined table #2803

glookka opened this issue Nov 30, 2024 · 2 comments
Assignees
Labels

Comments

@glookka
Copy link
Contributor

glookka commented Nov 30, 2024

Bug Description:

Currently there is no way to specify options like field_weights for the right table in JOIN statement. The suggestion is to use options(table_name) =... in SQL and this in json

  "options": {
    "table_name": {
       ...
    },
    "table_name2": {
       ...
    }
  }

When there's no join, options should look like this:

 "options": {
    "option": "value"
  }

Manticore Search Version:

6.3.1

Operating System Version:

Any

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@glookka glookka added the bug label Nov 30, 2024
@glookka glookka self-assigned this Nov 30, 2024
@glookka
Copy link
Contributor Author

glookka commented Dec 19, 2024

Done in cd1b93f

@glookka glookka closed this as completed Dec 19, 2024
@sanikolaev sanikolaev reopened this Dec 19, 2024
@sanikolaev
Copy link
Collaborator

@Nick-S-2018 please add the info about search options for join queries to the openapi yaml and ensure the generated clients can deal with it. The documentation can be found here https://manual.manticoresearch.com/dev/Searching/Joining#Query-options-and-match-weights

@sanikolaev sanikolaev assigned Nick-S-2018 and unassigned glookka Dec 19, 2024
@sanikolaev sanikolaev added the rel::upcoming Upcoming release label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants