Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate calc speedup (remove CheckReplaceEntry?) #1319

Closed
githubmanticore opened this issue Aug 2, 2023 · 4 comments
Closed

Aggregate calc speedup (remove CheckReplaceEntry?) #1319

githubmanticore opened this issue Aug 2, 2023 · 4 comments

Comments

@githubmanticore
Copy link
Contributor

We have a CSphImplicitGroupSorter::CheckReplaceEntry which copies one match to another if their rowid is less. This looks unnecessary because we are only calculating aggregates and rowid should not matter at all. We need to try to remove that func, run the tests and evaluate the consequences.

@githubmanticore
Copy link
Contributor Author

➤ Ilya Kuznetsov commented:

Relevant code was added in a5a1772

@githubmanticore
Copy link
Contributor Author

➤ Sergey Nikolaev commented:

To understand the priority of this please let me know how long would it take and what kind of queries would it improve and by how much?

@githubmanticore
Copy link
Contributor Author

➤ Ilya Kuznetsov commented:

3-4 hours. Any queries with aggregates and without grouping. By how much - no idea, depends on the data.

@githubmanticore
Copy link
Contributor Author

➤ Ilya Kuznetsov commented:

Done in 0a82cd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants