-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipe searchd.log to stderr by default? #22
Comments
@ksa-real what's your take on this? |
I don't have a strong opinion. When exporting to Loki or Elastic, the stream name is just another label. If using structured logging, the same effect can be achieved using an explicit label identifying the message type, e.g. type="query", or query="select some from ...". We are particularly looking into OpenTelemetry and structured logging. I'd say if using unstructured logging, do whatever is common in the industry. |
I'm not sure it's right to output non-errors to STDERR. Is there any official docker image or a helm chart which does that by default? I see here https://docs.docker.com/config/containers/logging/ that:
but nginx and httpd send errors to STDERR, not regular messages. |
It is from My goal at least is be able to seperate the logs. With both searchd and the query log intermingled its hard to seperate them. In theory query logs are easy to seperate as they have the comment at the start, but we have multiline queries, so there are lines that are hard to identify. |
As you said, you can configure this. I've discussed this with the team and we wouldn't like to change the defaults to avoid confusing users by the fact that non-errors can be only see in STDERR by default. I'm also not sure we need |
Ok, was just hoping it might help others. Was surprised when had an issue, and needed to look at searchd.log, that it was all intermingled. Would also be nice if hte logging could be configured more directly, not just having to redefine the entirety of the For background using Flux Helm Controller, so have an additional file, that applies an 'overlay' to values.yaml. |
I know we can configure this, be redefining values.config.content, but wonder if there is virtu in piping searchd to
stderr
by default?(leaving query log to
stdout
)log = /dev/stderr
https://github.com/manticoresoftware/manticoresearch-helm/blob/master/chart/values.yaml#L66
... This makes it much easier to inspect the logs, in systems that can separate stderr/stdout streams. We use loki to ingest logs from containers.
The text was updated successfully, but these errors were encountered: