Release v1.0?

[jrjohnson]

This addon has been stable for a long time and seems ready for a 1.0 release, it would be a huge help to addons using this package to have a 1.0 release as declaring ^1.0.0 in package.json wouldn't require an update when a new minor version is released. On the other hand the 0.3.0 release this week is going to require a lot of churn to ship across the ember ecosystem.

Thanks for a great addon!

[jrjohnson]

@mansona it looks like you bumped a release today, just wanted to ping you on this. 0.4.0 is going to once again cause a bunch of churn for dependency-lint enabled apps while addons get caught up. 1.0.0 would be much appreciated.

[bertdeblock]

I would like to echo what @jrjohnson is saying. We now need to, either create a PR for each addon using [email protected] (this will need to happen at some point though) or use e.g. Yarn resolutions. Having a v1 release would really be appreciated once the addon is compatible with Embroider.

[mansona]

@bertdeblock that is my plan, once I can get #29 passing and merged I'm planning to release a 1.0 👍

I have started a conversation in the Ember Discord #dev-embroider channel but I haven't had much traction 🤔 if anyone knows how to move this forward that would be a big help

[jrjohnson]

In FortAwesome/ember-fontawesome#174 @NullVoxPopuli suggested replacing this addon with import { getGlobalConfig } from '@embroider/macros';. I wasn't sure it was necessary because I had seen the embroider note that a comparability helper was added for this addon. If getting this addon working with embroider is a pain and that marco does the same thing it would probably make sense to freeze this addon and use the helper. But, and this is a big but, I don't actually know what getGlobalConfig does and it's not clear to me if using it is a good idea.

[mansona]

now that #29 is merged I have released v1.0.0 🎉

[jrjohnson]

Thanks for pushing this over the line!