From fd36da45c27d16de60c618d949d73feee4f0fdf4 Mon Sep 17 00:00:00 2001 From: Leo Li Date: Tue, 3 Nov 2026 16:21:32 -0800 Subject: [PATCH] Cloud start: a start refused on this Mac says why, and marks no step failed A Cloud start the pane refused before it reached Cloud (its folder is not one of the tab's, a Send without a gesture) showed "The app refused the agent connection." under a failed "Set up a Cloud machine" step, and logged nothing under app.cloud. - cloudStartEnded words a transport.* refusal by its code: a folder outside the tab's reads "This folder isn't open in this tab; pick it to send it to Cloud.", any other through transportErrors.errorMessage. - Such a refusal sets refusedHere, and the checklist marks no step failed. - AgentPaneHandOff.cloud logs the pane's own refusals under app.cloud. Co-Authored-By: Claude Opus 5.5 Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5 --- .../AgentPaneCloudStart.swift | 21 +++++++++++++++++++ .../acpmux/CloudStartView.test.tsx | 6 ++++++ .../agent-session/acpmux/CloudStartView.tsx | 3 ++- .../acpmux/Localizable.xcstrings | 1 + .../acpmux/cloudStartProgress.test.ts | 19 ++++++++++++++++- .../acpmux/cloudStartProgress.ts | 20 ++++++++++++++++-- 6 files changed, 66 insertions(+), 4 deletions(-) diff --git a/Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneCloudStart.swift b/Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneCloudStart.swift index 1d0feb8f7204..cf7efac62ea5 100644 --- a/Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneCloudStart.swift +++ b/Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneCloudStart.swift @@ -2,6 +2,7 @@ public import CmuxNextCloud import CmuxNextCompat public import CmuxNextSettings public import Foundation +import os /// `cloud.startChat {task, cwd?, harness?, model?, key}`: a new chat's first send with Cloud picked /// as where it runs (the environment picker's Cloud row, Labs). The App picks or makes a Cloud @@ -174,7 +175,27 @@ struct AgentPaneHandOff { } } + private static let cloudLog = Logger(subsystem: "com.cmuxterm.app.next", category: "app.cloud") + + /// `cloud.startChat`, and a refusal made here, before the App's start ran (the folder check, the + /// gesture, an attachment), logged under `app.cloud` beside the App's own start failures: such a + /// refusal never reaches CloudStartChat, so without this the log said nothing at all. func cloud(_ start: AgentPaneCloudStart) async -> [String: Any] { + let reply = await cloudChecked(start) + if let code = Self.refusedHere(reply) { + Self.cloudLog.error("cloud start chat refused on this Mac before it started: \(code, privacy: .public)") + } + return reply + } + + /// The reply's code when this pane refused the start itself (`transport.*`, `cloud_attachments`, + /// `unsupported`); nil for a success or the App's own failure. + nonisolated static func refusedHere(_ reply: [String: Any]) -> String? { + guard reply["ok"] as? Bool == false, let code = (reply["error"] as? [String: Any])?["code"] as? String else { return nil } + return code.hasPrefix("transport.") || code == "cloud_attachments" || code == "unsupported" ? code : nil + } + + private func cloudChecked(_ start: AgentPaneCloudStart) async -> [String: Any] { // The folder is a path on this Mac: a chat on another machine never names one to copy. guard let run = model.onCloudStartChat, !model.chatIsElsewhere else { return AgentPaneModel.unsupported("cloud.startChat") } guard AgentPaneCloudAttachments(start.attachments) != nil else { diff --git a/webviews/src/agent-session/acpmux/CloudStartView.test.tsx b/webviews/src/agent-session/acpmux/CloudStartView.test.tsx index bfed68ddef90..efca59053442 100644 --- a/webviews/src/agent-session/acpmux/CloudStartView.test.tsx +++ b/webviews/src/agent-session/acpmux/CloudStartView.test.tsx @@ -202,3 +202,9 @@ test("row state words are screen-reader only, hidden by the card's own sheet", a ); expect(html).toContain('