From 3e329e27717892f818269c02517d8e87efe0a353 Mon Sep 17 00:00:00 2001 From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com> Date: Wed, 30 Sep 2026 14:41:33 -0700 Subject: [PATCH 1/2] Pass the temporary-config flag to the Codex provider override parser #16201 made providerOverrides(from:) skip provider entries when the caller uses a temporary CODEX_HOME, but read `usesTemporaryConfig`, a parameter of build(configToml:usesTemporaryConfig:) that is not in scope there, so the CLI no longer compiles. Pass the flag through. Co-Authored-By: Claude Opus 5.5 (1M context) --- CLI/CMUXCLI+AutoNaming.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CLI/CMUXCLI+AutoNaming.swift b/CLI/CMUXCLI+AutoNaming.swift index ebcdd9be93b9..3d5442cf7d8e 100644 --- a/CLI/CMUXCLI+AutoNaming.swift +++ b/CLI/CMUXCLI+AutoNaming.swift @@ -232,14 +232,14 @@ struct CodexAutoNamingArguments: Sendable { arguments.insert("--ignore-user-config", at: arguments.firstIndex(of: "--ignore-rules")!) } guard let configToml else { return arguments } - let overrides = providerOverrides(from: configToml) + let overrides = providerOverrides(from: configToml, usesTemporaryConfig: usesTemporaryConfig) for override in overrides.reversed() { arguments.insert(contentsOf: ["-c", override], at: 1) } return arguments } - private static func providerOverrides(from toml: String) -> [String] { + private static func providerOverrides(from toml: String, usesTemporaryConfig: Bool) -> [String] { var model: String? var modelProvider: String? var providerEntries: [(section: String, key: String, value: String)] = [] From 3f8bd146d0840b4a32fff7e773c1347c0d66c99e Mon Sep 17 00:00:00 2001 From: Leo Li Date: Wed, 30 Sep 2026 18:16:02 -0400 Subject: [PATCH 2/2] test: match temporary Codex config argument scope --- cmuxCLITests/CodexAutoNamingArgumentsTests.swift | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmuxCLITests/CodexAutoNamingArgumentsTests.swift b/cmuxCLITests/CodexAutoNamingArgumentsTests.swift index e47dcbe9efc7..fc678561a288 100644 --- a/cmuxCLITests/CodexAutoNamingArgumentsTests.swift +++ b/cmuxCLITests/CodexAutoNamingArgumentsTests.swift @@ -41,7 +41,10 @@ struct CodexAutoNamingArgumentsTests { let overrides = configOverrides(args) #expect(overrides.contains("model_provider=\"subrouter\"")) #expect(overrides.contains("model=\"gpt-5-codex\"")) - #expect(overrides.contains("model_providers.subrouter.base_url=\"http://127.0.0.1:31415/v1\"")) + // With a temporary CODEX_HOME, the provider definition is already + // available in its mode-restricted config.toml. Do not duplicate it + // on argv, where nested provider values could expose credentials. + #expect(!overrides.contains("model_providers.subrouter.base_url=\"http://127.0.0.1:31415/v1\"")) #expect(!overrides.contains(where: { $0.contains("secret") || $0.contains("experimental_bearer_token") || $0.contains("api-secret") }))