Skip to content

test: Remove test for fallback to pickle #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

test: Remove test for fallback to pickle #805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions python/tests/unit/arcticdb/version_store/test_empty_writes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,38 +142,3 @@ def test_empty_series(lmdb_version_store_dynamic_schema, sym):
ser.index = ser.index.astype("datetime64[ns]")

assert_series_equal(lmdb_version_store_dynamic_schema.read(sym).data, ser)


def test_fallback_to_pickle(lmdb_version_store, sym):
column_names = ["a", "b", "c"]
df = pd.DataFrame(columns=column_names)
lmdb_version_store.write(sym, df)

# In Pandas 2.0, RangeIndex is used by default when an empty dataframe or series is created.
# The index is converted to a DatetimeIndex for preserving the behavior of ArcticDB with Pandas 1.0.
assert isinstance(df.index, pd.RangeIndex if IS_PANDAS_TWO else pd.Index)

if IS_PANDAS_TWO:
# In Pandas 2.0, RangeIndex is used by default when an empty dataframe or series is created.
# The index has to be converted to a DatetimeIndex by ArcticDB to perform updates.
df.index = df.index.astype("datetime64[ns]")

# Before Pandas 2.0, empty Series' dtype was "float64" and empty DataFrames' Columns' dtype was "object".
# As of Pandas 2.0, empty Series' dtype is "object" and empty DataFrames' Columns' dtype remains "object".
# See: https://github.com/pandas-dev/pandas/issues/17261
# When normalizing in Pandas 2.0, we convert empty Series' dtype to float to "float64" to be consistent
# with the behavior of ArcticDB with Pandas 1.0.
# The same logic is used to normalize empty DataFrames' columns.

# Hence:
if IS_PANDAS_TWO:
# In Pandas 2.0, empty Dataframes can now be stored without being pickled.
assert not lmdb_version_store.is_symbol_pickled(sym)
# and ArcticDB returns empty DataFrames with float64 for all columns if they have not been specified.
df = df.astype("float64", copy=False)
assert_frame_equal(df, lmdb_version_store.read(sym).data)
else:
# In Pandas 1.0, empty Dataframes are pickled.
assert lmdb_version_store.is_symbol_pickled(sym)
# and ArcticDB simply deserialize empty DataFrames.
assert_frame_equal(df, lmdb_version_store.read(sym).data)