Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparently not following semantic versioning #3808

Open
corneliusroemer opened this issue Feb 5, 2025 · 4 comments
Open

Apparently not following semantic versioning #3808

corneliusroemer opened this issue Feb 5, 2025 · 4 comments

Comments

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Feb 5, 2025

I've noticed that you've released lots of patch releases since v2 (we're now at 2.0.6) and they seem to have included new features, so I was wondering why you are not bumping the minor version, i.e. why we aren't on 2.1 yet, see e.g. these enhancements in latest release:

### 2.0.6

Enhancements:

[all] Add reverse flag to list command by @SandrineP in https://github.com/mamba-org/mamba/pull/3705
[all] Add md5 flag to list command by @SandrineP in https://github.com/mamba-org/mamba/pull/3773
[all] add canonical flag to list command by @SandrineP in https://github.com/mamba-org/mamba/pull/3777

### 2.0.5

Enhancements:

[all] micromamba/mamba --version displays pre-release version names + establishes pre-release versions name scheme by @Klaim in https://github.com/mamba-org/mamba/pull/3639

### 2.0.4

Enhancements:

[micromamba] feat: List PyPI packages in environment export by @jjerphan in https://github.com/mamba-org/mamba/pull/3623
[libmamba] More details in error message when failing to parse json from a python command's output by @Klaim in https://github.com/mamba-org/mamba/pull/3604
[libmamba] Fix: json parsing error due to wrong encoding of Python output by @Klaim in https://github.com/mamba-org/mamba/pull/3584
[libmamba] Adds logs clarifying the source of the error "could not load prefix data by @Klaim in https://github.com/mamba-org/mamba/pull/3581
[libmamba, micromamba] pip packages support with list by @Hind-M in https://github.com/mamba-org/mamba/pull/3565
[libmamba, libmambapy] chore: some CMake cleanup by @henryiii in https://github.com/mamba-org/mamba/pull/3564
[libmamba] Replaced rstrip reimplementation with call to remove_suffix by @JohanMabille in https://github.com/mamba-org/mamba/pull/3508
@maresb
Copy link
Contributor

maresb commented Feb 9, 2025

I believe it's just a matter of perspective. The new features are only really "new" to v2, so it's mostly that they're bringing it up to parity with v1, so it's more like fixing regressions. See #3535.

@corneliusroemer
Copy link
Contributor Author

@maresb Thanks I didn't know that - I guess in that case, the changelog is a tad bit misleading 😀

@jjerphan
Copy link
Member

Bug fixes and regressions are being addressed without any new features or breaking changes, hence the use of patch versions.

The changelog entries are automatically being generated, and PR title semantics is not enforced. We need to think of how to improve this IMO.

@JohanMabille
Copy link
Member

We have mistagged some PRs, the most of the "new features" are actually reintroducing subcommands and flags that were available in mamba 1 (but not micromamba). Besides, these fixes do not break the ABI backward compatibility, thus the patch releases and not minor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants