-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paddings -> offsets #10
Comments
Similar to my other comment on your other issue, this would complicate the implementation and usage of these methods, and make what they do slightly ambiguous and/or superfluous. Each method has a specific combination of parameters that apply specifically to each case, i.e. when anchoring to an edge, only |
Ok, what I actually dont like is the "Pad" suffix. I would make it yOffset and xOffset or at least yPadding and xPadding. You can still use xPad and yPad in method implementation, but using abbreviated version seems just wrong in swift or objc. Offsets seem a bit better since it is used thru iOS and OS X SDKs extensively. |
Yeah I don't disagree there - with these things I'm always struggling a bit to find the balance between succinctness, clarity, explicitness, etc. I'll think some more about this and get back to you. Thanks! |
Wouldnt it be fitting to refactor
xPad: CGFloat, yPad: CGFloat
type arguments to something nice likeoffset: CGSize
and/oroffset: UIEdgeInsets
. Seems a bit nicer to me, or at least provide it as overloads to current implementation :)The text was updated successfully, but these errors were encountered: