Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support React 16 #190

Closed
renanpvaz opened this issue Oct 6, 2017 · 3 comments
Closed

Update to support React 16 #190

renanpvaz opened this issue Oct 6, 2017 · 3 comments

Comments

@renanpvaz
Copy link

renanpvaz commented Oct 6, 2017 •
edited
Loading

These are the breaking changes: https://github.com/facebook/react/releases/tag/v16.0.0.
I tried running your tests with react 16.0.0 and made some fixes, still this test won't pass. If you have any idea of what it could be I can fix it and send a PR.
@ohmyhusky
Copy link

Maybe it's because of React 16's new SSR strategy? The style won't be updated in some situations. facebook/react#10591

@renanpvaz
Copy link
Author

@cyl19910101 any ideas of what could fix it?

@malte-wessel
Copy link
Owner

Should be fixed with v4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@malte-wessel @ohmyhusky @renanpvaz