From a134a0e2a01757fdda24c862970d86410edc7a90 Mon Sep 17 00:00:00 2001 From: Doug Barker Date: Mon, 17 Nov 2025 17:50:16 -0500 Subject: [PATCH] [CODE HEALTH] turn on the `cppcoreguidelines-init-variables` check and fix warnings (#3751) --- .clang-tidy | 1 - api/test/common/kv_properties_test.cc | 8 +- api/test/nostd/shared_ptr_test.cc | 2 +- api/test/nostd/unique_ptr_test.cc | 4 +- ci/do_ci.sh | 15 +++ examples/grpc/client.cc | 7 +- examples/grpc/server.cc | 6 +- examples/http/client.cc | 6 +- .../src/console_push_metric_builder.cc | 3 +- exporters/otlp/src/otlp_environment.cc | 118 +++++++++--------- exporters/otlp/src/otlp_grpc_client.cc | 2 +- exporters/prometheus/src/exporter_options.cc | 8 +- ext/src/http/client/curl/http_client_curl.cc | 4 +- .../http/client/curl/http_operation_curl.cc | 21 ++-- ext/test/http/url_parser_test.cc | 4 +- .../w3c_tracecontext_http_test_server/main.cc | 8 +- sdk/src/common/base64.cc | 21 ++-- sdk/src/common/disabled.cc | 5 +- sdk/src/configuration/configuration_parser.cc | 6 +- sdk/src/configuration/document_node.cc | 25 ++-- sdk/src/configuration/sdk_builder.cc | 42 +++---- .../yaml_configuration_parser.cc | 4 +- sdk/src/logs/batch_log_record_processor.cc | 2 +- .../batch_log_record_processor_options.cc | 4 +- .../base2_exponential_histogram_indexer.cc | 2 +- sdk/src/trace/batch_span_processor.cc | 2 +- sdk/src/trace/batch_span_processor_options.cc | 4 +- sdk/src/trace/samplers/trace_id_ratio.cc | 3 +- sdk/test/common/env_var_test.cc | 10 +- 29 files changed, 166 insertions(+), 181 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index db61b810c9..452fbaf014 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -35,7 +35,6 @@ Checks: > -cppcoreguidelines-avoid-do-while, -cppcoreguidelines-avoid-c-arrays, -cppcoreguidelines-avoid-magic-numbers, - -cppcoreguidelines-init-variables, -cppcoreguidelines-macro-usage, -cppcoreguidelines-non-private-member-variables-in-classes, -cppcoreguidelines-avoid-non-const-global-variables, diff --git a/api/test/common/kv_properties_test.cc b/api/test/common/kv_properties_test.cc index 8815214e45..f85e8f38c7 100644 --- a/api/test/common/kv_properties_test.cc +++ b/api/test/common/kv_properties_test.cc @@ -66,7 +66,7 @@ using opentelemetry::common::KeyValueStringTokenizerOptions; TEST(KVStringTokenizer, SinglePair) { - bool valid_kv; + bool valid_kv{}; nostd::string_view key, value; opentelemetry::nostd::string_view str = "k1=v1"; KeyValueStringTokenizerOptions opts; @@ -80,7 +80,7 @@ TEST(KVStringTokenizer, SinglePair) TEST(KVStringTokenizer, AcceptEmptyEntries) { - bool valid_kv; + bool valid_kv{}; nostd::string_view key, value; opentelemetry::nostd::string_view str = ":k1=v1::k2=v2: "; KeyValueStringTokenizerOptions opts; @@ -104,7 +104,7 @@ TEST(KVStringTokenizer, AcceptEmptyEntries) TEST(KVStringTokenizer, ValidPairsWithEmptyEntries) { opentelemetry::nostd::string_view str = "k1:v1===k2:v2=="; - bool valid_kv; + bool valid_kv{}; nostd::string_view key, value; KeyValueStringTokenizerOptions opts; opts.member_separator = '='; @@ -128,7 +128,7 @@ TEST(KVStringTokenizer, InvalidPairs) { opentelemetry::nostd::string_view str = "k1=v1,invalid ,, k2=v2 ,invalid"; KeyValueStringTokenizer tk(str); - bool valid_kv; + bool valid_kv{}; nostd::string_view key, value; EXPECT_TRUE(tk.next(valid_kv, key, value)); diff --git a/api/test/nostd/shared_ptr_test.cc b/api/test/nostd/shared_ptr_test.cc index fa3d97c493..be5f6ddd5e 100644 --- a/api/test/nostd/shared_ptr_test.cc +++ b/api/test/nostd/shared_ptr_test.cc @@ -98,7 +98,7 @@ TEST(SharedPtrTest, MoveConstructionFromStdSharedPtr) TEST(SharedPtrTest, Destruction) { - bool was_destructed; + bool was_destructed{}; shared_ptr{new A{was_destructed}}; // NOLINT EXPECT_TRUE(was_destructed); } diff --git a/api/test/nostd/unique_ptr_test.cc b/api/test/nostd/unique_ptr_test.cc index 3660bc5d22..8307135355 100644 --- a/api/test/nostd/unique_ptr_test.cc +++ b/api/test/nostd/unique_ptr_test.cc @@ -81,7 +81,7 @@ TEST(UniquePtrTest, MoveConstructionFromStdUniquePtr) TEST(UniquePtrTest, Destruction) { - bool was_destructed; + bool was_destructed{}; unique_ptr{new A{was_destructed}}; // NOLINT EXPECT_TRUE(was_destructed); } @@ -127,7 +127,7 @@ TEST(UniquePtrTest, PointerOperators) TEST(UniquePtrTest, Reset) { - bool was_destructed1; + bool was_destructed1{}; unique_ptr ptr{new A{was_destructed1}}; bool was_destructed2 = true; ptr.reset(new A{was_destructed2}); diff --git a/ci/do_ci.sh b/ci/do_ci.sh index 9022ef301b..ddeffe74da 100755 --- a/ci/do_ci.sh +++ b/ci/do_ci.sh @@ -338,6 +338,21 @@ elif [[ "$1" == "cmake.legacy.test" ]]; then make -j $(nproc) make test exit 0 +elif [[ "$1" == "cmake.clang_tidy.test" ]]; then + cd "${BUILD_DIR}" + rm -rf * + export BUILD_ROOT="${BUILD_DIR}" + cmake -S ${SRC_DIR} \ + -B ${BUILD_DIR} \ + -C ${SRC_DIR}/test_common/cmake/all-options-abiv2-preview.cmake \ + "${CMAKE_OPTIONS[@]}" \ + -DWITH_OPENTRACING=OFF \ + -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \ + -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ + -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--quiet;-p;${BUILD_DIR}" + make -j $(nproc) + make test + exit 0 elif [[ "$1" == "cmake.legacy.exporter.otprotocol.test" ]]; then cd "${BUILD_DIR}" rm -rf * diff --git a/examples/grpc/client.cc b/examples/grpc/client.cc index 0d7227c6b9..3abdda7421 100644 --- a/examples/grpc/client.cc +++ b/examples/grpc/client.cc @@ -127,15 +127,12 @@ int main(int argc, char **argv) opentelemetry::nostd::shared_ptr( new propagation::HttpTraceContext())); constexpr uint16_t default_port = 8800; - uint16_t port; + uint16_t port{default_port}; if (argc > 1) { port = static_cast(atoi(argv[1])); } - else - { - port = default_port; - } + RunClient(port); CleanupTracer(); return 0; diff --git a/examples/grpc/server.cc b/examples/grpc/server.cc index d863926984..e9e5e4d5a6 100644 --- a/examples/grpc/server.cc +++ b/examples/grpc/server.cc @@ -127,15 +127,11 @@ int main(int argc, char **argv) { InitTracer(); constexpr uint16_t default_port = 8800; - uint16_t port; + uint16_t port{default_port}; if (argc > 1) { port = static_cast(atoi(argv[1])); } - else - { - port = default_port; - } RunServer(port); CleanupTracer(); diff --git a/examples/http/client.cc b/examples/http/client.cc index 589b9adeea..2434126596 100644 --- a/examples/http/client.cc +++ b/examples/http/client.cc @@ -99,17 +99,13 @@ int main(int argc, char *argv[]) constexpr char default_host[] = "localhost"; constexpr char default_path[] = "/helloworld"; constexpr uint16_t default_port = 8800; - uint16_t port; + uint16_t port{default_port}; // The port the validation service listens to can be specified via the command line. if (argc > 1) { port = static_cast(atoi(argv[1])); } - else - { - port = default_port; - } std::string url = "http://" + std::string(default_host) + ":" + std::to_string(port) + std::string(default_path); diff --git a/exporters/ostream/src/console_push_metric_builder.cc b/exporters/ostream/src/console_push_metric_builder.cc index 5569d7345b..0573f20ccb 100644 --- a/exporters/ostream/src/console_push_metric_builder.cc +++ b/exporters/ostream/src/console_push_metric_builder.cc @@ -31,7 +31,8 @@ void ConsolePushMetricBuilder::Register(opentelemetry::sdk::configuration::Regis std::unique_ptr ConsolePushMetricBuilder::Build( const opentelemetry::sdk::configuration::ConsolePushMetricExporterConfiguration *model) const { - sdk::metrics::AggregationTemporality aggregation_temporality; + sdk::metrics::AggregationTemporality aggregation_temporality{ + sdk::metrics::AggregationTemporality::kUnspecified}; switch (model->temporality_preference) { diff --git a/exporters/otlp/src/otlp_environment.cc b/exporters/otlp/src/otlp_environment.cc index a7bc95b321..e8aae45898 100644 --- a/exporters/otlp/src/otlp_environment.cc +++ b/exporters/otlp/src/otlp_environment.cc @@ -32,7 +32,7 @@ namespace otlp static bool GetBoolDualEnvVar(const char *signal_name, const char *generic_name, bool &value) { - bool exists; + bool exists{}; exists = sdk_common::GetBoolEnvironmentVariable(signal_name, value); if (exists) @@ -49,7 +49,7 @@ static bool GetDurationDualEnvVar(const char *signal_name, const char *generic_name, std::chrono::system_clock::duration &value) { - bool exists; + bool exists{}; exists = sdk_common::GetDurationEnvironmentVariable(signal_name, value); if (exists) @@ -66,7 +66,7 @@ static bool GetStringDualEnvVar(const char *signal_name, const char *generic_name, std::string &value) { - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(signal_name, value); if (exists) @@ -83,7 +83,7 @@ static bool GetUintDualEnvVar(const char *signal_name, const char *generic_name, std::uint32_t &value) { - bool exists; + bool exists{}; exists = sdk_common::GetUintEnvironmentVariable(signal_name, value); if (exists) @@ -98,7 +98,7 @@ static bool GetUintDualEnvVar(const char *signal_name, static bool GetFloatDualEnvVar(const char *signal_name, const char *generic_name, float &value) { - bool exists; + bool exists{}; exists = sdk_common::GetFloatEnvironmentVariable(signal_name, value); if (exists) @@ -118,7 +118,7 @@ std::string GetOtlpDefaultGrpcTracesEndpoint() constexpr char kDefault[] = "http://localhost:4317"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); @@ -137,7 +137,7 @@ std::string GetOtlpDefaultGrpcMetricsEndpoint() constexpr char kDefault[] = "http://localhost:4317"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); @@ -156,7 +156,7 @@ std::string GetOtlpDefaultGrpcLogsEndpoint() constexpr char kDefault[] = "http://localhost:4317"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); @@ -175,7 +175,7 @@ std::string GetOtlpDefaultHttpTracesEndpoint() constexpr char kDefault[] = "http://localhost:4318/v1/traces"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -200,7 +200,7 @@ std::string GetOtlpDefaultHttpMetricsEndpoint() constexpr char kDefault[] = "http://localhost:4318/v1/metrics"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -225,7 +225,7 @@ std::string GetOtlpDefaultHttpLogsEndpoint() constexpr char kDefault[] = "http://localhost:4318/v1/logs"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -250,7 +250,7 @@ std::string GetOtlpDefaultHttpTracesProtocol() constexpr char kDefault[] = "http/protobuf"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -274,7 +274,7 @@ std::string GetOtlpDefaultHttpMetricsProtocol() constexpr char kDefault[] = "http/protobuf"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -298,7 +298,7 @@ std::string GetOtlpDefaultHttpLogsProtocol() constexpr char kDefault[] = "http/protobuf"; std::string value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(kSignalEnv, value); if (exists) @@ -336,9 +336,9 @@ bool GetOtlpDefaultGrpcTracesIsInsecure() constexpr char kOldSignalEnv[] = "OTEL_EXPORTER_OTLP_TRACES_SSL_ENABLE"; constexpr char kOldGenericEnv[] = "OTEL_EXPORTER_OTLP_SSL_ENABLE"; - bool insecure; - bool ssl_enabled; - bool exists; + bool insecure{}; + bool ssl_enabled{}; + bool exists{}; exists = GetBoolDualEnvVar(kSignalEnv, kGenericEnv, insecure); if (exists) @@ -394,9 +394,9 @@ bool GetOtlpDefaultGrpcMetricsIsInsecure() constexpr char kOldSignalEnv[] = "OTEL_EXPORTER_OTLP_METRICS_SSL_ENABLE"; constexpr char kOldGenericEnv[] = "OTEL_EXPORTER_OTLP_SSL_ENABLE"; - bool insecure; - bool ssl_enabled; - bool exists; + bool insecure{}; + bool ssl_enabled{}; + bool exists{}; exists = GetBoolDualEnvVar(kSignalEnv, kGenericEnv, insecure); if (exists) @@ -450,8 +450,8 @@ bool GetOtlpDefaultGrpcLogsIsInsecure() constexpr char kSignalEnv[] = "OTEL_EXPORTER_OTLP_LOGS_INSECURE"; constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_INSECURE"; - bool insecure; - bool exists; + bool insecure{}; + bool exists{}; exists = GetBoolDualEnvVar(kSignalEnv, kGenericEnv, insecure); if (exists) @@ -468,7 +468,7 @@ std::string GetOtlpDefaultTracesSslCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -485,7 +485,7 @@ std::string GetOtlpDefaultMetricsSslCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -502,7 +502,7 @@ std::string GetOtlpDefaultLogsSslCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -519,7 +519,7 @@ std::string GetOtlpDefaultTracesSslCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -536,7 +536,7 @@ std::string GetOtlpDefaultMetricsSslCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -553,7 +553,7 @@ std::string GetOtlpDefaultLogsSslCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -570,7 +570,7 @@ std::string GetOtlpDefaultTracesSslClientKeyPath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -587,7 +587,7 @@ std::string GetOtlpDefaultMetricsSslClientKeyPath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -604,7 +604,7 @@ std::string GetOtlpDefaultLogsSslClientKeyPath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -621,7 +621,7 @@ std::string GetOtlpDefaultTracesSslClientKeyString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -638,7 +638,7 @@ std::string GetOtlpDefaultMetricsSslClientKeyString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -655,7 +655,7 @@ std::string GetOtlpDefaultLogsSslClientKeyString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_KEY_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -672,7 +672,7 @@ std::string GetOtlpDefaultTracesSslClientCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -689,7 +689,7 @@ std::string GetOtlpDefaultMetricsSslClientCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -706,7 +706,7 @@ std::string GetOtlpDefaultLogsSslClientCertificatePath() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -723,7 +723,7 @@ std::string GetOtlpDefaultTracesSslClientCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -740,7 +740,7 @@ std::string GetOtlpDefaultMetricsSslClientCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -757,7 +757,7 @@ std::string GetOtlpDefaultLogsSslClientCertificateString() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE_STRING"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -780,7 +780,7 @@ std::string GetOtlpDefaultTracesSslTlsMinVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MIN_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -797,7 +797,7 @@ std::string GetOtlpDefaultMetricsSslTlsMinVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MIN_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -814,7 +814,7 @@ std::string GetOtlpDefaultLogsSslTlsMinVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MIN_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -831,7 +831,7 @@ std::string GetOtlpDefaultTracesSslTlsMaxVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MAX_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -848,7 +848,7 @@ std::string GetOtlpDefaultMetricsSslTlsMaxVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MAX_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -865,7 +865,7 @@ std::string GetOtlpDefaultLogsSslTlsMaxVersion() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_MAX_TLS"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -882,7 +882,7 @@ std::string GetOtlpDefaultTracesSslTlsCipher() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -899,7 +899,7 @@ std::string GetOtlpDefaultMetricsSslTlsCipher() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -916,7 +916,7 @@ std::string GetOtlpDefaultLogsSslTlsCipher() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -933,7 +933,7 @@ std::string GetOtlpDefaultTracesSslTlsCipherSuite() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER_SUITE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -950,7 +950,7 @@ std::string GetOtlpDefaultMetricsSslTlsCipherSuite() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER_SUITE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -967,7 +967,7 @@ std::string GetOtlpDefaultLogsSslTlsCipherSuite() constexpr char kGenericEnv[] = "OTEL_CPP_EXPORTER_OTLP_CIPHER_SUITE"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -984,7 +984,7 @@ std::chrono::system_clock::duration GetOtlpDefaultTracesTimeout() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_TIMEOUT"; std::chrono::system_clock::duration value; - bool exists; + bool exists{}; exists = GetDurationDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -1002,7 +1002,7 @@ std::chrono::system_clock::duration GetOtlpDefaultMetricsTimeout() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_TIMEOUT"; std::chrono::system_clock::duration value; - bool exists; + bool exists{}; exists = GetDurationDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -1020,7 +1020,7 @@ std::chrono::system_clock::duration GetOtlpDefaultLogsTimeout() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_TIMEOUT"; std::chrono::system_clock::duration value; - bool exists; + bool exists{}; exists = GetDurationDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -1035,7 +1035,7 @@ std::chrono::system_clock::duration GetOtlpDefaultLogsTimeout() static void DumpOtlpHeaders(OtlpHeaders &output, const char *env_var_name) { std::string raw_value; - bool exists; + bool exists{}; exists = sdk_common::GetStringEnvironmentVariable(env_var_name, raw_value); @@ -1111,7 +1111,7 @@ std::string GetOtlpDefaultTracesCompression() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_COMPRESSION"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -1128,7 +1128,7 @@ std::string GetOtlpDefaultMetricsCompression() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_COMPRESSION"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) @@ -1145,7 +1145,7 @@ std::string GetOtlpDefaultLogsCompression() constexpr char kGenericEnv[] = "OTEL_EXPORTER_OTLP_COMPRESSION"; std::string value; - bool exists; + bool exists{}; exists = GetStringDualEnvVar(kSignalEnv, kGenericEnv, value); if (exists) diff --git a/exporters/otlp/src/otlp_grpc_client.cc b/exporters/otlp/src/otlp_grpc_client.cc index b2000aadce..02ec8d6a4e 100644 --- a/exporters/otlp/src/otlp_grpc_client.cc +++ b/exporters/otlp/src/otlp_grpc_client.cc @@ -766,7 +766,7 @@ bool OtlpGrpcClient::Shutdown(OtlpGrpcClientReferenceGuard &guard, } bool last_reference_removed = RemoveReference(guard); - bool force_flush_result; + bool force_flush_result{}; if (last_reference_removed && false == is_shutdown_.exchange(true, std::memory_order_acq_rel)) { OTEL_INTERNAL_LOG_DEBUG("[OTLP GRPC Client] DEBUG: OtlpGrpcClient start to shutdown"); diff --git a/exporters/prometheus/src/exporter_options.cc b/exporters/prometheus/src/exporter_options.cc index 122baf5198..0798f47cf9 100644 --- a/exporters/prometheus/src/exporter_options.cc +++ b/exporters/prometheus/src/exporter_options.cc @@ -29,7 +29,7 @@ inline bool GetPrometheusWithoutOtelScope() { constexpr char kPrometheusWithoutOtelScope[] = "OTEL_CPP_PROMETHEUS_EXPORTER_WITHOUT_OTEL_SCOPE"; - bool setting; + bool setting{}; auto exists = opentelemetry::sdk::common::GetBoolEnvironmentVariable(kPrometheusWithoutOtelScope, setting); @@ -41,7 +41,7 @@ inline bool GetPrometheusPopulateTargetInfo() constexpr char kPrometheusPopulateTargetInfo[] = "OTEL_CPP_PROMETHEUS_EXPORTER_POPULATE_TARGET_INFO"; - bool setting; + bool setting{}; auto exists = opentelemetry::sdk::common::GetBoolEnvironmentVariable( kPrometheusPopulateTargetInfo, setting); @@ -51,7 +51,7 @@ inline bool GetPrometheusPopulateTargetInfo() inline bool GetPrometheusWithoutUnits() { constexpr char kPrometheusWithoutUnits[] = "OTEL_CPP_PROMETHEUS_EXPORTER_WITHOUT_UNITS"; - bool setting; + bool setting{}; const auto exists = opentelemetry::sdk::common::GetBoolEnvironmentVariable(kPrometheusWithoutUnits, setting); @@ -62,7 +62,7 @@ inline bool GetPrometheusWithoutTypeSuffix() { constexpr char kPrometheusWithoutTypeSuffix[] = "OTEL_CPP_PROMETHEUS_EXPORTER_WITHOUT_TYPE_SUFFIX"; - bool setting; + bool setting{}; const auto exists = opentelemetry::sdk::common::GetBoolEnvironmentVariable(kPrometheusWithoutTypeSuffix, setting); diff --git a/ext/src/http/client/curl/http_client_curl.cc b/ext/src/http/client/curl/http_client_curl.cc index 77105398d3..7c5ddd19e8 100644 --- a/ext/src/http/client/curl/http_client_curl.cc +++ b/ext/src/http/client/curl/http_client_curl.cc @@ -782,8 +782,8 @@ bool HttpClient::doAbortSessions() bool HttpClient::doRemoveSessions() { - bool has_data = false; - bool should_continue; + bool has_data{false}; + bool should_continue{false}; do { std::unordered_map pending_to_remove_session_handles; diff --git a/ext/src/http/client/curl/http_operation_curl.cc b/ext/src/http/client/curl/http_operation_curl.cc index 3fd27c9634..56a9519012 100644 --- a/ext/src/http/client/curl/http_operation_curl.cc +++ b/ext/src/http/client/curl/http_operation_curl.cc @@ -575,7 +575,7 @@ static long parse_max_ssl_version(const std::string &version) const char *HttpOperation::GetCurlErrorMessage(CURLcode code) { - const char *message; + const char *message{nullptr}; if (curl_error_message_[0] != '\0') { @@ -593,8 +593,6 @@ const char *HttpOperation::GetCurlErrorMessage(CURLcode code) CURLcode HttpOperation::SetCurlPtrOption(CURLoption option, void *value) { - CURLcode rc; - /* curl_easy_setopt() is a macro with variadic arguments, type unsafe. Various SetCurlXxxOption() helpers ensure it is called with a pointer, @@ -603,7 +601,7 @@ CURLcode HttpOperation::SetCurlPtrOption(CURLoption option, void *value) - a blob (struct curl_blob*) - a headers chunk (curl_slist *) */ - rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); + const CURLcode rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); if (rc != CURLE_OK) { @@ -618,13 +616,11 @@ CURLcode HttpOperation::SetCurlPtrOption(CURLoption option, void *value) // NOLINTNEXTLINE(google-runtime-int) CURLcode HttpOperation::SetCurlLongOption(CURLoption option, long value) { - CURLcode rc; - /* curl_easy_setopt() is a macro with variadic arguments, type unsafe. SetCurlLongOption() ensures it is called with a long. */ - rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); + const CURLcode rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); if (rc != CURLE_OK) { @@ -638,13 +634,11 @@ CURLcode HttpOperation::SetCurlLongOption(CURLoption option, long value) CURLcode HttpOperation::SetCurlOffOption(CURLoption option, curl_off_t value) { - CURLcode rc; - /* curl_easy_setopt() is a macro with variadic arguments, type unsafe. SetCurlOffOption() ensures it is called with a curl_off_t. */ - rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); + const CURLcode rc = curl_easy_setopt(curl_resource_.easy_handle, option, value); if (rc != CURLE_OK) { @@ -732,21 +726,20 @@ CURLcode HttpOperation::Setup() return CURLE_FAILED_INIT; } - CURLcode rc; - curl_error_message_[0] = '\0'; curl_easy_setopt(curl_resource_.easy_handle, CURLOPT_ERRORBUFFER, curl_error_message_); // Support for custom debug function callback was added in version 7.9.6 so we guard against // exposing the default CURL output by keeping verbosity always disabled in lower versions. #if LIBCURL_VERSION_NUM < CURL_VERSION_BITS(7, 9, 6) - rc = SetCurlLongOption(CURLOPT_VERBOSE, 0L); + CURLcode rc = SetCurlLongOption(CURLOPT_VERBOSE, 0L); if (rc != CURLE_OK) { return rc; } #else - rc = SetCurlLongOption(CURLOPT_VERBOSE, (is_log_enabled_ && kEnableCurlLogging) ? 1L : 0L); + CURLcode rc = + SetCurlLongOption(CURLOPT_VERBOSE, (is_log_enabled_ && kEnableCurlLogging) ? 1L : 0L); if (rc != CURLE_OK) { return rc; diff --git a/ext/test/http/url_parser_test.cc b/ext/test/http/url_parser_test.cc index 450bdd424c..729891a85b 100644 --- a/ext/test/http/url_parser_test.cc +++ b/ext/test/http/url_parser_test.cc @@ -15,10 +15,10 @@ struct ParsedUrl { std::string scheme; std::string host; - std::uint16_t port; + std::uint16_t port{}; std::string path; std::string query; - bool success; + bool success{}; friend void PrintTo(const ParsedUrl &p, std::ostream *os) { diff --git a/ext/test/w3c_tracecontext_http_test_server/main.cc b/ext/test/w3c_tracecontext_http_test_server/main.cc index 1ee3a2d511..57edb0860b 100644 --- a/ext/test/w3c_tracecontext_http_test_server/main.cc +++ b/ext/test/w3c_tracecontext_http_test_server/main.cc @@ -110,7 +110,7 @@ nostd::shared_ptr get_tracer() struct Uri { std::string host; - uint16_t port; + uint16_t port{}; std::string path; Uri(const std::string &uri) @@ -179,7 +179,7 @@ int main(int argc, char *argv[]) constexpr char default_host[] = "localhost"; constexpr uint16_t default_port = 30000; - uint16_t port; + uint16_t port{default_port}; std::atomic_bool stop_server(false); // The port the validation service listens to can be specified via the command line. @@ -187,10 +187,6 @@ int main(int argc, char *argv[]) { port = static_cast(atoi(argv[1])); } - else - { - port = default_port; - } auto root_span = get_tracer()->StartSpan(__func__); trace_api::Scope scope(root_span); diff --git a/sdk/src/common/base64.cc b/sdk/src/common/base64.cc index b6da954677..ce4e2f6722 100644 --- a/sdk/src/common/base64.cc +++ b/sdk/src/common/base64.cc @@ -44,9 +44,13 @@ static int Base64EscapeInternal(unsigned char *dest, Base64EscapeChars &base64_enc_map, unsigned char padding_char) { - std::size_t i, n, nopadding; - int C1, C2, C3; - unsigned char *p; + std::size_t i{}; + std::size_t n{}; + std::size_t nopadding{}; + int C1{}; + int C2{}; + int C3{}; + unsigned char *p{nullptr}; if (slen == 0) { @@ -161,10 +165,13 @@ static int Base64UnescapeInternal(unsigned char *dst, Base64UnescapeChars &base64_dec_map, unsigned char padding_char) { - std::size_t i, n; - std::size_t j, x; - std::size_t valid_slen, line_len; - unsigned char *p; + std::size_t i{}; + std::size_t n{}; + std::size_t j{}; + std::size_t x{}; + std::size_t valid_slen{}; + std::size_t line_len{}; + unsigned char *p{nullptr}; /* First pass: check for validity and get output length */ for (i = n = j = valid_slen = line_len = 0; i < slen; i++) diff --git a/sdk/src/common/disabled.cc b/sdk/src/common/disabled.cc index 340f4cffee..b49eb922a1 100644 --- a/sdk/src/common/disabled.cc +++ b/sdk/src/common/disabled.cc @@ -15,10 +15,9 @@ bool GetSdkDisabled() { constexpr char kEnv[] = "OTEL_SDK_DISABLED"; - bool exists; - bool value; + bool value{}; - exists = GetBoolEnvironmentVariable(kEnv, value); + const bool exists = GetBoolEnvironmentVariable(kEnv, value); if (!exists) { value = false; diff --git a/sdk/src/configuration/configuration_parser.cc b/sdk/src/configuration/configuration_parser.cc index 8b0f0d4794..439ff5f67c 100644 --- a/sdk/src/configuration/configuration_parser.cc +++ b/sdk/src/configuration/configuration_parser.cc @@ -1975,9 +1975,9 @@ std::unique_ptr ConfigurationParser::Parse(std::unique_ptrfile_format = node->GetRequiredString("file_format"); { - int count; - int major; - int minor; + int count{}; + int major{}; + int minor{}; count = sscanf(model->file_format.c_str(), "%d.%d", &major, &minor); if (count != 2) diff --git a/sdk/src/configuration/document_node.cc b/sdk/src/configuration/document_node.cc index 7b83b40731..f5aafe9f76 100644 --- a/sdk/src/configuration/document_node.cc +++ b/sdk/src/configuration/document_node.cc @@ -31,14 +31,13 @@ std::string DocumentNode::DoSubstitution(const std::string &text) const std::string result; - std::string::size_type current_pos; - std::string::size_type begin_pos; - std::string::size_type end_pos; + std::string::size_type current_pos{}; + std::string::size_type begin_pos{}; + std::string::size_type end_pos{}; std::string copy; std::string substitution; - current_pos = 0; - begin_pos = text.find(begin_token); + begin_pos = text.find(begin_token); while (begin_pos != std::string::npos) { @@ -96,17 +95,17 @@ std::string DocumentNode::DoOneSubstitution(const std::string &text) const static std::string env_with_replacement{"env:-"}; static std::string replacement_token{":-"}; - size_t len = text.length(); - char c; - std::string::size_type begin_name; - std::string::size_type end_name; - std::string::size_type begin_fallback; - std::string::size_type end_fallback; - std::string::size_type pos; + const std::size_t len{text.length()}; + char c{}; + std::string::size_type begin_name{}; + std::string::size_type end_name{}; + std::string::size_type begin_fallback{}; + std::string::size_type end_fallback{}; + std::string::size_type pos{}; std::string name; std::string fallback; std::string sub; - bool env_exists; + bool env_exists{}; if (len < 4) { diff --git a/sdk/src/configuration/sdk_builder.cc b/sdk/src/configuration/sdk_builder.cc index a00b181890..92352c51ba 100644 --- a/sdk/src/configuration/sdk_builder.cc +++ b/sdk/src/configuration/sdk_builder.cc @@ -825,9 +825,7 @@ std::unique_ptr SdkBuilder::CreateOtlpH const opentelemetry::sdk::configuration::OtlpHttpSpanExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpHttpSpanExporterBuilder *builder; - - builder = registry_->GetOtlpHttpSpanBuilder(); + const OtlpHttpSpanExporterBuilder *builder = registry_->GetOtlpHttpSpanBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpHttpSpanExporter() using registered http builder"); @@ -843,9 +841,7 @@ std::unique_ptr SdkBuilder::CreateOtlpG const opentelemetry::sdk::configuration::OtlpGrpcSpanExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpGrpcSpanExporterBuilder *builder; - - builder = registry_->GetOtlpGrpcSpanBuilder(); + const OtlpGrpcSpanExporterBuilder *builder = registry_->GetOtlpGrpcSpanBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpGrpcSpanExporter() using registered grpc builder"); @@ -861,9 +857,7 @@ std::unique_ptr SdkBuilder::CreateOtlpF const opentelemetry::sdk::configuration::OtlpFileSpanExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpFileSpanExporterBuilder *builder; - - builder = registry_->GetOtlpFileSpanBuilder(); + const OtlpFileSpanExporterBuilder *builder = registry_->GetOtlpFileSpanBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpFileSpanExporter() using registered file builder"); @@ -1147,7 +1141,8 @@ SdkBuilder::CreatePropagator( static opentelemetry::sdk::metrics::InstrumentType ConvertInstrumentType( enum opentelemetry::sdk::configuration::InstrumentType config) { - opentelemetry::sdk::metrics::InstrumentType sdk; + opentelemetry::sdk::metrics::InstrumentType sdk{ + opentelemetry::sdk::metrics::InstrumentType::kCounter}; switch (config) { @@ -1183,9 +1178,8 @@ SdkBuilder::CreateOtlpHttpPushMetricExporter( const opentelemetry::sdk::configuration::OtlpHttpPushMetricExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpHttpPushMetricExporterBuilder *builder; - - builder = registry_->GetOtlpHttpPushMetricExporterBuilder(); + const OtlpHttpPushMetricExporterBuilder *builder = + registry_->GetOtlpHttpPushMetricExporterBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpHttpPushMetricExporter() using registered http builder"); @@ -1202,9 +1196,8 @@ SdkBuilder::CreateOtlpGrpcPushMetricExporter( const opentelemetry::sdk::configuration::OtlpGrpcPushMetricExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpGrpcPushMetricExporterBuilder *builder; - - builder = registry_->GetOtlpGrpcPushMetricExporterBuilder(); + const OtlpGrpcPushMetricExporterBuilder *builder = + registry_->GetOtlpGrpcPushMetricExporterBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpGrpcPushMetricExporter() using registered grpc builder"); @@ -1221,9 +1214,8 @@ SdkBuilder::CreateOtlpFilePushMetricExporter( const opentelemetry::sdk::configuration::OtlpFilePushMetricExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpFilePushMetricExporterBuilder *builder; - - builder = registry_->GetOtlpFilePushMetricExporterBuilder(); + const OtlpFilePushMetricExporterBuilder *builder = + registry_->GetOtlpFilePushMetricExporterBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpFilePushMetricExporter() using registered file builder"); @@ -1532,9 +1524,7 @@ SdkBuilder::CreateOtlpHttpLogRecordExporter( const opentelemetry::sdk::configuration::OtlpHttpLogRecordExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpHttpLogRecordExporterBuilder *builder; - - builder = registry_->GetOtlpHttpLogRecordBuilder(); + const OtlpHttpLogRecordExporterBuilder *builder = registry_->GetOtlpHttpLogRecordBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpHttpLogRecordExporter() using registered http builder"); @@ -1551,9 +1541,7 @@ SdkBuilder::CreateOtlpGrpcLogRecordExporter( const opentelemetry::sdk::configuration::OtlpGrpcLogRecordExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpGrpcLogRecordExporterBuilder *builder; - - builder = registry_->GetOtlpGrpcLogRecordBuilder(); + const OtlpGrpcLogRecordExporterBuilder *builder = registry_->GetOtlpGrpcLogRecordBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpGrpcLogRecordExporter() using registered grpc builder"); @@ -1570,9 +1558,7 @@ SdkBuilder::CreateOtlpFileLogRecordExporter( const opentelemetry::sdk::configuration::OtlpFileLogRecordExporterConfiguration *model) const { std::unique_ptr sdk; - const OtlpFileLogRecordExporterBuilder *builder; - - builder = registry_->GetOtlpFileLogRecordBuilder(); + const OtlpFileLogRecordExporterBuilder *builder = registry_->GetOtlpFileLogRecordBuilder(); if (builder != nullptr) { OTEL_INTERNAL_LOG_DEBUG("CreateOtlpFileLogRecordExporter() using registered file builder"); diff --git a/sdk/src/configuration/yaml_configuration_parser.cc b/sdk/src/configuration/yaml_configuration_parser.cc index 7c95b1c895..26d1213f03 100644 --- a/sdk/src/configuration/yaml_configuration_parser.cc +++ b/sdk/src/configuration/yaml_configuration_parser.cc @@ -32,8 +32,8 @@ std::unique_ptr YamlConfigurationParser::ParseFile(const std::str { static std::string env_var_name("OTEL_EXPERIMENTAL_CONFIG_FILE"); std::string env_var; - bool env_exists; - env_exists = sdk::common::GetStringEnvironmentVariable(env_var_name.c_str(), env_var); + const bool env_exists = + sdk::common::GetStringEnvironmentVariable(env_var_name.c_str(), env_var); if (env_exists) { diff --git a/sdk/src/logs/batch_log_record_processor.cc b/sdk/src/logs/batch_log_record_processor.cc index a656ef1f64..8a03e44d7d 100644 --- a/sdk/src/logs/batch_log_record_processor.cc +++ b/sdk/src/logs/batch_log_record_processor.cc @@ -255,7 +255,7 @@ void BatchLogRecordProcessor::Export() do { std::vector> records_arr; - size_t num_records_to_export; + size_t num_records_to_export{}; std::uint64_t notify_force_flush = synchronization_data_->force_flush_pending_sequence.load(std::memory_order_acquire); if (notify_force_flush) diff --git a/sdk/src/logs/batch_log_record_processor_options.cc b/sdk/src/logs/batch_log_record_processor_options.cc index 2d6ec741be..4b867c9ab2 100644 --- a/sdk/src/logs/batch_log_record_processor_options.cc +++ b/sdk/src/logs/batch_log_record_processor_options.cc @@ -27,7 +27,7 @@ const size_t kDefaultMaxExportBatchSize = 512; inline size_t GetMaxQueueSizeFromEnv() { - std::uint32_t value; + std::uint32_t value{}; if (!opentelemetry::sdk::common::GetUintEnvironmentVariable(kMaxQueueSizeEnv, value)) { return kDefaultMaxQueueSize; @@ -49,7 +49,7 @@ inline std::chrono::milliseconds GetDurationFromEnv( inline size_t GetMaxExportBatchSizeFromEnv() { - std::uint32_t value; + std::uint32_t value{}; if (!opentelemetry::sdk::common::GetUintEnvironmentVariable(kMaxExportBatchSizeEnv, value)) { return kDefaultMaxExportBatchSize; diff --git a/sdk/src/metrics/aggregation/base2_exponential_histogram_indexer.cc b/sdk/src/metrics/aggregation/base2_exponential_histogram_indexer.cc index a46a2775e5..20c4dad7c0 100644 --- a/sdk/src/metrics/aggregation/base2_exponential_histogram_indexer.cc +++ b/sdk/src/metrics/aggregation/base2_exponential_histogram_indexer.cc @@ -33,7 +33,7 @@ int32_t MapToIndexScaleZero(double value) // Note: std::frexp() rounds submnormal values to the smallest normal value and returns an // exponent corresponding to fractions in the range [0.5, 1), whereas an exponent for the range // [1, 2), so subtract 1 from the exponent immediately. - int exp; + int exp{}; double frac = std::frexp(value, &exp); exp--; diff --git a/sdk/src/trace/batch_span_processor.cc b/sdk/src/trace/batch_span_processor.cc index ad93eae7ae..7991929779 100644 --- a/sdk/src/trace/batch_span_processor.cc +++ b/sdk/src/trace/batch_span_processor.cc @@ -245,7 +245,7 @@ void BatchSpanProcessor::Export() do { std::vector> spans_arr; - size_t num_records_to_export; + size_t num_records_to_export{}; std::uint64_t notify_force_flush = synchronization_data_->force_flush_pending_sequence.load(std::memory_order_acquire); if (notify_force_flush) diff --git a/sdk/src/trace/batch_span_processor_options.cc b/sdk/src/trace/batch_span_processor_options.cc index c9e51e16ac..d8570946f3 100644 --- a/sdk/src/trace/batch_span_processor_options.cc +++ b/sdk/src/trace/batch_span_processor_options.cc @@ -27,7 +27,7 @@ const size_t kDefaultMaxExportBatchSize = 512; inline size_t GetMaxQueueSizeFromEnv() { - std::uint32_t value; + std::uint32_t value{}; if (!opentelemetry::sdk::common::GetUintEnvironmentVariable(kMaxQueueSizeEnv, value)) { return kDefaultMaxQueueSize; @@ -49,7 +49,7 @@ inline std::chrono::milliseconds GetDurationFromEnv( inline size_t GetMaxExportBatchSizeFromEnv() { - std::uint32_t value; + std::uint32_t value{}; if (!opentelemetry::sdk::common::GetUintEnvironmentVariable(kMaxExportBatchSizeEnv, value)) { return kDefaultMaxExportBatchSize; diff --git a/sdk/src/trace/samplers/trace_id_ratio.cc b/sdk/src/trace/samplers/trace_id_ratio.cc index 6d7009fedf..9a9b31b977 100644 --- a/sdk/src/trace/samplers/trace_id_ratio.cc +++ b/sdk/src/trace/samplers/trace_id_ratio.cc @@ -41,7 +41,8 @@ uint64_t CalculateThreshold(double ratio) noexcept // For probabilities >= 1-(2^-54), the product wraps to zero! // Instead, calculate the high and low 32 bits separately. const double product = UINT32_MAX * ratio; - double hi_bits, lo_bits = ldexp(modf(product, &hi_bits), 32) + product; + double hi_bits{}; + double lo_bits = ldexp(modf(product, &hi_bits), 32) + product; return (static_cast(hi_bits) << 32) + static_cast(lo_bits); } diff --git a/sdk/test/common/env_var_test.cc b/sdk/test/common/env_var_test.cc index b4cc0d2e12..dc89bb40d8 100644 --- a/sdk/test/common/env_var_test.cc +++ b/sdk/test/common/env_var_test.cc @@ -34,7 +34,7 @@ TEST(EnvVarTest, BoolEnvVar) setenv("BOOL_ENV_VAR_F3", "FaLsE", 1); setenv("BOOL_ENV_VAR_BROKEN", "Maybe ?", 1); - bool exists; + bool exists{}; bool value = true; exists = GetBoolEnvironmentVariable("BOOL_ENV_VAR_NONE", value); @@ -97,7 +97,7 @@ TEST(EnvVarTest, StringEnvVar) setenv("STRING_ENV_VAR_EMPTY", "", 1); setenv("STRING_ENV_VAR", "my string", 1); - bool exists; + bool exists{}; std::string value; exists = GetStringEnvironmentVariable("STRING_ENV_VAR_NONE", value); @@ -130,7 +130,7 @@ TEST(EnvVarTest, DurationEnvVar) setenv("DURATION_ENV_VAR_BROKEN_1", "123 ms", 1); setenv("DURATION_ENV_VAR_BROKEN_2", "1mississippi", 1); - bool exists; + bool exists{}; std::chrono::system_clock::duration poison; std::chrono::system_clock::duration value; std::chrono::system_clock::duration expected; @@ -231,7 +231,7 @@ TEST(EnvVarTest, UintEnvVar) setenv("UINT_ENV_VAR_WITH_NOISE", " \t \n 9.12345678.9", 1); setenv("UINT_ENV_VAR_ONLY_SPACES", " ", 1); - std::uint32_t value; + std::uint32_t value{}; ASSERT_FALSE(GetUintEnvironmentVariable("UINT_ENV_VAR_NONE", value)); @@ -295,7 +295,7 @@ TEST(EnvVarTest, FloatEnvVar) setenv("FLOAT_ENV_VAR_WITH_NOISE", " \t \n 9.12345678.9", 1); setenv("FLOAT_ENV_VAR_ONLY_SPACES", " ", 1); - float value; + float value{}; ASSERT_FALSE(GetFloatEnvironmentVariable("FLOAT_ENV_VAR_NONE", value));