From 24000ad95017ed93aeab13cc02d428048f9ca80c Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Sat, 29 Feb 2020 01:29:31 -0800 Subject: [PATCH] docs: clean up systemPreferences.effectiveAppearance text * Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given https://github.com/electron/electron-packager/pull/1131 --- docs/api/system-preferences.md | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/docs/api/system-preferences.md b/docs/api/system-preferences.md index 6975ef35fc3bf..64abfeaeafae0 100644 --- a/docs/api/system-preferences.md +++ b/docs/api/system-preferences.md @@ -371,11 +371,11 @@ maps to [NSApplication.effectiveAppearance](https://developer.apple.com/document Please note that until Electron is built targeting the 10.14 SDK, your application's `effectiveAppearance` will default to 'light' and won't inherit the OS preference. In -the interim in order for your application to inherit the OS preference you must set the -`NSRequiresAquaSystemAppearance` key in your apps `Info.plist` to `false`. If you are -using `electron-packager` or `electron-forge` just set the `enableDarwinDarkMode` -packager option to `true`. See the [Electron Packager API](https://github.com/electron/electron-packager/blob/master/docs/api.md#darwindarkmodesupport) -for more details. +the interim, in order for your application to inherit the OS preference, you must set the +`NSRequiresAquaSystemAppearance` key in your app's `Info.plist` to `false`. If you are +using [Electron Packager][electron-packager] or [Electron Forge][electron-forge], set the +`darwinDarkModeSupport` packager option to `true`. See the [Electron Packager +API][packager-darwindarkmode-api] for more details. **[Deprecated](modernization/property-updates.md)** @@ -481,8 +481,12 @@ maps to [NSApplication.effectiveAppearance](https://developer.apple.com/document Please note that until Electron is built targeting the 10.14 SDK, your application's `effectiveAppearance` will default to 'light' and won't inherit the OS preference. In -the interim in order for your application to inherit the OS preference you must set the -`NSRequiresAquaSystemAppearance` key in your apps `Info.plist` to `false`. If you are -using `electron-packager` or `electron-forge` just set the `enableDarwinDarkMode` -packager option to `true`. See the [Electron Packager API](https://github.com/electron/electron-packager/blob/master/docs/api.md#darwindarkmodesupport) -for more details. +the interim, in order for your application to inherit the OS preference, you must set the +`NSRequiresAquaSystemAppearance` key in your app's `Info.plist` to `false`. If you are +using [Electron Packager][electron-packager] or [Electron Forge][electron-forge], set the +`darwinDarkModeSupport` packager option to `true`. See the [Electron Packager +API][packager-darwindarkmode-api] for more details. + +[electron-forge]: https://www.electronforge.io/ +[electron-packager]: https://github.com/electron/electron-packager +[packager-darwindarkmode-api]: https://electron.github.io/electron-packager/master/interfaces/electronpackager.options.html#darwindarkmodesupport