-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beefing up m4ri.pc #2
Comments
This sounds like a good idea, thanks! |
Getting a better .pc file is very nice but I forgot about the other platforms that may not have pkg-config handy. While pkgconfig will be useful when present we may have to keep AX_M4RI_CFLAGS for when it is not available. Which is slightly annoying. |
True, shall we merge #3 anyway, or is that on hold. Sorry, lost track. |
On hold, there is one more bit I want to add. I have an editor window opened on configure.ac and started to add some stuff... but it is at work and I haven't had time to finish it before leaving. |
I have been a bad boy and completely forgot about finishing. And now I don't remember what exactly I wanted to add. Hum... have to test things on a platform without pkg-config, my OS X laptop is the designed victim. |
I am preparing a new release of BRiAl and it strikes me that the way BRiAl and m4rie access the flags from m4ri is suboptimal.
Instead of of using AX_M4RI_CFLAGS we should just use the output of of pkg-config. To make it even more interesting I think it should include the library flags for openmp and libpng. Also the optimization flags used don't really belong there. The consumer of m4ri should be able to set its own without worrying about what is in m4ri.pc.
If you think that is a worthwhile idea I'll send a pull request.
The text was updated successfully, but these errors were encountered: