Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beefing up m4ri.pc #2

Open
kiwifb opened this issue Jun 7, 2017 · 5 comments
Open

Beefing up m4ri.pc #2

kiwifb opened this issue Jun 7, 2017 · 5 comments

Comments

@kiwifb
Copy link
Contributor

kiwifb commented Jun 7, 2017

I am preparing a new release of BRiAl and it strikes me that the way BRiAl and m4rie access the flags from m4ri is suboptimal.
Instead of of using AX_M4RI_CFLAGS we should just use the output of of pkg-config. To make it even more interesting I think it should include the library flags for openmp and libpng. Also the optimization flags used don't really belong there. The consumer of m4ri should be able to set its own without worrying about what is in m4ri.pc.
If you think that is a worthwhile idea I'll send a pull request.

@malb
Copy link
Owner

malb commented Jun 7, 2017

This sounds like a good idea, thanks!

@kiwifb kiwifb mentioned this issue Jun 8, 2017
@kiwifb
Copy link
Contributor Author

kiwifb commented Jun 8, 2017

Getting a better .pc file is very nice but I forgot about the other platforms that may not have pkg-config handy. While pkgconfig will be useful when present we may have to keep AX_M4RI_CFLAGS for when it is not available. Which is slightly annoying.

@malb
Copy link
Owner

malb commented Jun 9, 2017

True, shall we merge #3 anyway, or is that on hold. Sorry, lost track.

@kiwifb
Copy link
Contributor Author

kiwifb commented Jun 9, 2017

On hold, there is one more bit I want to add. I have an editor window opened on configure.ac and started to add some stuff... but it is at work and I haven't had time to finish it before leaving.

@kiwifb
Copy link
Contributor Author

kiwifb commented Mar 8, 2018

I have been a bad boy and completely forgot about finishing. And now I don't remember what exactly I wanted to add. Hum... have to test things on a platform without pkg-config, my OS X laptop is the designed victim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants