Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Handling of duplicate domain entries for DNSMasq #2

Open
maksimkurb opened this issue Jan 28, 2025 · 0 comments · May be fixed by #3
Open

Incorrect Handling of duplicate domain entries for DNSMasq #2

maksimkurb opened this issue Jan 28, 2025 · 0 comments · May be fixed by #3

Comments

@maksimkurb
Copy link
Owner

maksimkurb commented Jan 28, 2025 •
edited
Loading

When a domain is listed in multiple ipset configurations, dnsmasq generates separate entries for each ipset instead of combining them into a single row. For example:

ipset=/ifconfig.co/vpn
ipset=/ifconfig.co/vpn_ipv6

This should instead be:

ipset=/ifconfig.co/vpn,vpn_ipv6

Impact:

Domain is added only in the first ipset (vpn) instead of all ipsets (vpn, vpn_ipv6)

Solution Needed:

Update the logic to ensure only one row is written per domain, combining all relevant ipset names into a single entry.
maksimkurb added a commit that referenced this issue Feb 2, 2025
@maksimkurb
Process all lists completely before writing them to dnsmasq. Fixes #2
4dafa24
@maksimkurb maksimkurb linked a pull request Feb 2, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dnsmasq ipset handing maksimkurb/keenetic-pbr
1 participant
@maksimkurb