Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When bookmarking a page, suggest a title based on the first level 1 heading #267

Closed
mntn-xyz opened this issue Nov 4, 2021 · 4 comments · Fixed by #293
Closed

When bookmarking a page, suggest a title based on the first level 1 heading #267

mntn-xyz opened this issue Nov 4, 2021 · 4 comments · Fixed by #293
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@mntn-xyz
Copy link
Contributor

mntn-xyz commented Nov 4, 2021

I usually just retype a short version of the heading, what do other people do?

@makew0rld
Copy link
Owner

I often write something custom, but this is a good suggestion. Low priority but something that would be nice to have for sure.

@makew0rld makew0rld added the enhancement New feature or request label Nov 4, 2021
@makew0rld
Copy link
Owner

Also, if this was added, there would have to be some way to show that the bookmark already exists when pressing Ctrl-D on a page. Right now I'm able to tell when a bookmark is already there because the text of the bookmark title shows up pre-filled. If this was added there would almost always be something pre-filled.

@mntn-xyz
Copy link
Contributor Author

Currently for existing bookmarks it shows a "change or remove" dialog (with the current bookmark name) instead of the "add" dialog.

@makew0rld
Copy link
Owner

Oh yeah ha, good point.

@makew0rld makew0rld added this to the v1.10.0 milestone Dec 8, 2021
@makew0rld makew0rld added the documentation Improvements or additions to documentation label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants