Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected link & scrolling doesn't stay for non-cached pages #122

Closed
makew0rld opened this issue Nov 19, 2020 · 1 comment
Closed

Selected link & scrolling doesn't stay for non-cached pages #122

makew0rld opened this issue Nov 19, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@makew0rld
Copy link
Owner

makew0rld commented Nov 19, 2020

Scroll position is part of structs.Page, which means that it isn't remembered if pages aren't cached. But this is bad UX when navigating back and forth on long un-cached pages. An example of this is Astrobotany, which uses client certs (and is therefore not cached according to current logic), and has a long page that lists all the plants.

Possible solutions

  • Enable caching for client cert pages, and find some other solution to the problem of caching dynamic pages
  • Store scroll data elsewhere, like in a new array of structs for history ✔️
  • ...
@makew0rld makew0rld added enhancement New feature or request question Further information is requested labels Nov 19, 2020
@makew0rld makew0rld changed the title Scrolling doesn't stay for non-cached pages Selected link & scrolling doesn't stay for non-cached pages Dec 27, 2020
@makew0rld
Copy link
Owner Author

This also applies to remembering what link was selected/highlighted. I've edited the title to reflect this.

This is a problem not just for client cert pages, but also about: pages, especially ones like about:subscriptions.

@makew0rld makew0rld modified the milestones: v1.8.0, v1.9.0 Dec 27, 2020
@makew0rld makew0rld modified the milestones: v1.9.0, v1.10.0 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant