feat: loading states update #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriramveeraghanta
approved these changes
Feb 13, 2024
| import { getRandomLength } from "../helper"; | ||
|
|
||
| export const GanttLayoutLoader = () => ( | ||
| <div className="flex flex-col h-full overflow-x-auto animate-pulse"> |
There was a problem hiding this comment.
These loaders are very hard to read, can you please break it down into further components? we cant identify which div is for which part of the loader. Can you please change them in all the loaders which have loong files
ghost
approved these changes
Feb 13, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rahulramesha
approved these changes
Feb 13, 2024
sriramveeraghanta
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces skeleton loaders across various layout and components, enhancing the user experience with a consistent loading interface. Skeleton loaders have been implemented in the following areas:
By replacing inconsistent spinner loaders with skeleton loaders, this PR ensures a smoother transition during data loading, offering users a more cohesive and intuitive experience.
This PR is linked to [PLE-328]
Media