Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: estimate order not maintained in create/ update modal. #3326

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Jan 8, 2024

Problem

Following the update to version v0.14-dev, there's a bug affecting the order of estimates. Users have reported that despite setting estimates in a specific order, the system automatically reorders them alphabetically upon saving. This behavior is a deviation from previous versions where the user-defined order was maintained.

Steps to Reproduce:

  1. Go to the estimates page.
  2. Create a new estimate or edit an existing one.
  3. Enter estimates in a non-alphabetical order (e.g., 1, 2, 3, 5, 8, 12).
  4. Save the estimates.
  5. Reopen or edit the estimates and observe the reordering has changed. (1, 12, 2, 3, 5, 8)

Solution

The issue was due to unsorted data in the create/ update modal. The backend sends estimate points in {key, value} pairs, with keys indicating order. To resolve it, I sorted these pairs by key value for proper ordering.

Reference

estimate.ordering.1.mp4

Other Issues Fixed:

  • Estimate Points were not mutation on update.

@prateekshourya29 prateekshourya29 added 🐛bug Something isn't working 🌐frontend labels Jan 8, 2024
@prateekshourya29 prateekshourya29 added this to the v0.14.3-dev milestone Jan 8, 2024
@prateekshourya29 prateekshourya29 self-assigned this Jan 8, 2024
@sriramveeraghanta sriramveeraghanta merged commit a71491e into develop Jan 8, 2024
7 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/estimates-ordering branch January 8, 2024 10:46
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
* fix: estimate order not maintained in create/ update modal.

* fix: estimate points mutation on update.
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
* fix: estimate order not maintained in create/ update modal.

* fix: estimate points mutation on update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants