Skip to content

Commit 62607ad

Browse files
authored
disable peek overview for temporary issues until it is confirmed (#3749)
1 parent d73cd2e commit 62607ad

File tree

6 files changed

+11
-2
lines changed

6 files changed

+11
-2
lines changed

packages/ui/src/control-link/control-link.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ export type TControlLink = React.AnchorHTMLAttributes<HTMLAnchorElement> & {
55
onClick: () => void;
66
children: React.ReactNode;
77
target?: string;
8+
disabled?: boolean;
89
};
910

1011
export const ControlLink: React.FC<TControlLink> = (props) => {
11-
const { href, onClick, children, target = "_self", ...rest } = props;
12+
const { href, onClick, children, target = "_self", disabled = false, ...rest } = props;
1213
const LEFT_CLICK_EVENT_CODE = 0;
1314

1415
const _onClick = (event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) => {
@@ -19,6 +20,8 @@ export const ControlLink: React.FC<TControlLink> = (props) => {
1920
}
2021
};
2122

23+
if (disabled) return <>{children}</>;
24+
2225
return (
2326
<a href={href} target={target} onClick={_onClick} {...rest}>
2427
{children}

web/components/issues/issue-layouts/calendar/issue-blocks.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ export const CalendarIssueBlocks: React.FC<Props> = observer((props) => {
7979
target="_blank"
8080
onClick={() => handleIssuePeekOverview(issue)}
8181
className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
82+
disabled={!!issue?.tempId}
8283
>
8384
<>
8485
{issue?.tempId !== undefined && (

web/components/issues/issue-layouts/gantt/blocks.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export const IssueGanttBlock: React.FC<Props> = observer((props) => {
2929
const handleIssuePeekOverview = () =>
3030
workspaceSlug &&
3131
issueDetails &&
32+
!issueDetails.tempId &&
3233
setPeekIssue({ workspaceSlug, projectId: issueDetails.project_id, issueId: issueDetails.id });
3334

3435
return (
@@ -89,8 +90,9 @@ export const IssueGanttSidebarBlock: React.FC<Props> = observer((props) => {
8990
target="_blank"
9091
onClick={handleIssuePeekOverview}
9192
className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
93+
disabled={!!issueDetails?.tempId}
9294
>
93-
<div className="relative flex h-full w-full cursor-pointer items-center gap-2" onClick={handleIssuePeekOverview}>
95+
<div className="relative flex h-full w-full cursor-pointer items-center gap-2">
9496
{stateDetails && <StateGroupIcon stateGroup={stateDetails?.group} color={stateDetails?.color} />}
9597
<div className="flex-shrink-0 text-xs text-custom-text-300">
9698
{projectDetails?.identifier} {issueDetails?.sequence_id}

web/components/issues/issue-layouts/kanban/block.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ const KanbanIssueDetailsBlock: React.FC<IssueDetailsBlockProps> = observer((prop
8282
target="_blank"
8383
onClick={() => handleIssuePeekOverview(issue)}
8484
className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
85+
disabled={!!issue?.tempId}
8586
>
8687
<Tooltip tooltipHeading="Title" tooltipContent={issue.name}>
8788
<span>{issue.name}</span>

web/components/issues/issue-layouts/list/block.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export const IssueBlock: React.FC<IssueBlockProps> = observer((props: IssueBlock
7676
target="_blank"
7777
onClick={() => handleIssuePeekOverview(issue)}
7878
className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
79+
disabled={!!issue?.tempId}
7980
>
8081
<Tooltip tooltipHeading="Title" tooltipContent={issue.name}>
8182
<span>{issue.name}</span>

web/components/issues/issue-layouts/spreadsheet/issue-row.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,7 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
239239
target="_blank"
240240
onClick={() => handleIssuePeekOverview(issueDetail)}
241241
className="clickable w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
242+
disabled={!!issueDetail?.tempId}
242243
>
243244
<div className="w-full overflow-hidden">
244245
<Tooltip tooltipHeading="Title" tooltipContent={issueDetail.name}>

0 commit comments

Comments
 (0)