💥 BREAKING CHANGE(idivmod): Move to remainder instead of quotient.

make-github-pseudonymous-again · make-github-pseudonymous-again · commit 6c9b905a3345 · 2020-05-04T17:41:48.000+02:00
diff --git a/src/Integer.js b/src/Integer.js
@@ -333,7 +333,7 @@ export class Integer {
 	idivmod ( other ) {
 		// TODO optimize but be careful with side effects
 		const [ q , r ] = this.divmod(other) ;
-		return [ q.move(this) , r ] ;
+		return [ q , r.move(this) ] ;
 	}
 
 	opposite ( ) {
diff --git a/test/src/Integer/divmod.js b/test/src/Integer/divmod.js
@@ -9,7 +9,7 @@ function macro ( t , a , b , q , r ) {
 
 	t.is(q.toString(), Q.toString()) ;
 	t.is(r.toString(), R.toString()) ;
-	t.is(q.toString(), A.toString()) ;
+	t.is(r.toString(), A.toString()) ;
 }
 
 macro.title = ( providedTitle , a , b , q , r ) => `${a} idivmod ${b} = [${q}, ${r}]` ;

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ export class Integer {`
`333`	`333`	`idivmod ( other ) {`
`334`	`334`	`// TODO optimize but be careful with side effects`
`335`	`335`	`const [ q , r ] = this.divmod(other) ;`
`336`		`- return [ q.move(this) , r ] ;`
	`336`	`+ return [ q , r.move(this) ] ;`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`opposite ( ) {`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ function macro ( t , a , b , q , r ) {`
`9`	`9`
`10`	`10`	`t.is(q.toString(), Q.toString()) ;`
`11`	`11`	`t.is(r.toString(), R.toString()) ;`
`12`		`- t.is(q.toString(), A.toString()) ;`
	`12`	`+ t.is(r.toString(), A.toString()) ;`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	macro.title = ( providedTitle , a , b , q , r ) => `${a} idivmod ${b} = [${q}, ${r}]` ;