Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump istio.io/client-go from 1.11.4 to 1.15.2 #1097

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build(deps): Bump istio.io/client-go from 1.11.4 to 1.15.2 #1097

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2022 •
edited
Loading

Bumps istio.io/client-go from 1.11.4 to 1.15.2.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Dependabot: Pull requests that update a dependency file go Dependabot: Pull requests that update Go code labels Oct 17, 2022
@dependabot dependabot bot requested a review from bartoszmajsak October 17, 2022 00:09
@dependabot dependabot bot mentioned this pull request Oct 17, 2022
Closed
@bartoszmajsak
Copy link
Contributor

@dependabot recreate

1 similar comment
@bartoszmajsak
Copy link
Contributor

@dependabot recreate

@dependabot
build(deps): Bump istio.io/client-go from 1.11.4 to 1.15.2
75ac560 
Bumps [istio.io/client-go](https://github.com/istio/client-go) from 1.11.4 to 1.15.2.
- [Release notes](https://github.com/istio/client-go/releases)
- [Commits](istio/client-go@v1.11.4...v1.15.2)

---
updated-dependencies:
- dependency-name: istio.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/istio.io/client-go-1.15.2 branch from bd91034 to 75ac560 Compare October 28, 2022 07:41
@bartoszmajsak bartoszmajsak added the reason/breaking-changes Reason: dependency update with compatibility issues label Oct 28, 2022
@bartoszmajsak
Copy link
Contributor

There are API incompat with the newer version of istio client and k8s apis. I guess we have to stick with older one for a time being.

# github.com/maistra/istio-workspace/pkg/istio
pkg/istio/destinationrule.go:41:43: cannot use &destinationRule (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule) as type client.Object in argument to reference.GetRefMarker:
	**"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule does not implement client.Object (missing DeepCopyObject method)
pkg/istio/destinationrule.go:73:40: cannot use &resource (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule) as type client.Object in argument to reference.GetRefMarker:
	**"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule does not implement client.Object (missing DeepCopyObject method)
pkg/istio/destinationrule.go:196:27: cannot use &dr (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule) as type *"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule in argument to locateSubset
pkg/istio/destinationrule.go:198:12: cannot use &dr (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule) as type *"istio.io/client-go/pkg/apis/networking/v1alpha3".DestinationRule in return statement
pkg/istio/virtualservice.go:49:43: cannot use &vs (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService) as type client.Object in argument to reference.GetRefMarker:
	**"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService does not implement client.Object (missing DeepCopyObject method)
pkg/istio/virtualservice.go:75:40: cannot use &vs (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService) as type client.Object in argument to reference.GetRefMarker:
	**"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService does not implement client.Object (missing DeepCopyObject method)
pkg/istio/virtualservice.go:93:38: cannot use vs (variable of type *"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService) as type "istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService in argument to connectedToGateway
pkg/istio/virtualservice.go:113:24: cannot use vs (variable of type *"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService) as type "istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService in argument to mutationRequired
pkg/istio/virtualservicegateway.go:33:43: cannot use &gw (value of type **"istio.io/client-go/pkg/apis/networking/v1alpha3".Gateway) as type client.Object in argument to reference.GetRefMarker:
	**"istio.io/client-go/pkg/apis/networking/v1alpha3".Gateway does not implement client.Object (missing DeepCopyObject method)
pkg/istio/virtualservicegateway.go:52:49: cannot use vs (variable of type *"istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService) as type "istio.io/client-go/pkg/apis/networking/v1alpha3".VirtualService in argument to connectedToGateway
pkg/istio/virtualservicegateway.go:52:49: too many errors

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 31, 2022

A newer version of istio.io/client-go exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak Awaiting requested review from bartoszmajsak

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Dependabot: Pull requests that update a dependency file go Dependabot: Pull requests that update Go code reason/breaking-changes Reason: dependency update with compatibility issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartoszmajsak