Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error autologin on serial tty #242

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

KwadFan
Copy link
Member

@KwadFan KwadFan commented Oct 2, 2023

This fixes issue that after connection to a
serial console it trys to autologin with user 'orangepi',
which does not exist in our images

Signed-off-by: Stephan Wendel [email protected]

This PR includes:

feat: add workaround for orangepi images
Apply release file workaround for OrangePI based images.

Signed-off-by: Stephan Wendel [email protected]

This fixes issue that after connection to a
serial console it trys to autologin with user 'orangepi',
which does not exist in our images

Signed-off-by: Stephan Wendel <[email protected]>
Apply release file workaround for OrangePI based images.

Signed-off-by: Stephan Wendel <[email protected]>
@KwadFan KwadFan added the bug Something isn't working label Oct 2, 2023
@KwadFan KwadFan requested a review from meteyou October 2, 2023 18:34
@KwadFan KwadFan self-assigned this Oct 2, 2023
Didnt obey rules for unpacking,
so files went to wron location and get ignored.

Signed-off-by: Stephan Wendel <[email protected]>
This should be the better approach to disable autologin on getty's
If those changes in future this might work better than fixed files.

Signed-off-by: Stephan Wendel <[email protected]>
Signed-off-by: Stephan Wendel <[email protected]>
Signed-off-by: Stephan Wendel <[email protected]>
@KwadFan KwadFan merged commit be13745 into mainsail-crew:develop Oct 17, 2023
8 checks passed
@KwadFan KwadFan deleted the fix/orangepi branch October 17, 2023 15:10
KwadFan added a commit to KwadFan/MainsailOS-dev that referenced this pull request Oct 17, 2023
Since we applied PR mainsail-crew#241 and PR mainsail-crew#242
This function always returns no value.
Which leads to errors in enabling SPI Interface by default.

This should fix this behaviour

Signed-off-by: Stephan Wendel <[email protected]>
KwadFan added a commit to KwadFan/MainsailOS-dev that referenced this pull request Oct 17, 2023
Since we applied PR mainsail-crew#241 and mainsail-crew#242,
this function always doesnt give the right value,
which leads to unwanted behaviour in enabling SPI during build.

As we no longer rename the release file,
we have to use its original location in '/etc/armbian-release'
( Or '/etc/orangepi-release' if Opi Image is used )

Signed-off-by: Stephan Wendel <[email protected]>
KwadFan added a commit that referenced this pull request Oct 20, 2023
Since we applied PR #241 and #242,
this function always doesnt give the right value,
which leads to unwanted behaviour in enabling SPI during build.

As we no longer rename the release file,
we have to use its original location in '/etc/armbian-release'
( Or '/etc/orangepi-release' if Opi Image is used )

Signed-off-by: Stephan Wendel <[email protected]>
KwadFan added a commit to KwadFan/MainsailOS-dev that referenced this pull request Oct 28, 2023
* fix: fix autologin on serial tty

This fixes issue that after connection to a
serial console it trys to autologin with user 'orangepi',
which does not exist in our images

Signed-off-by: Stephan Wendel <[email protected]>

* feat: add workaround for orangepi images

Apply release file workaround for OrangePI based images.

Signed-off-by: Stephan Wendel <[email protected]>
KwadFan added a commit to KwadFan/MainsailOS-dev that referenced this pull request Oct 28, 2023
Since we applied PR mainsail-crew#241 and mainsail-crew#242,
this function always doesnt give the right value,
which leads to unwanted behaviour in enabling SPI during build.

As we no longer rename the release file,
we have to use its original location in '/etc/armbian-release'
( Or '/etc/orangepi-release' if Opi Image is used )

Signed-off-by: Stephan Wendel <[email protected]>
miklschmidt pushed a commit to Rat-OS/RatOS that referenced this pull request Feb 25, 2024
* fix: fix autologin on serial tty

This fixes issue that after connection to a
serial console it trys to autologin with user 'orangepi',
which does not exist in our images

Signed-off-by: Stephan Wendel <[email protected]>

* feat: add workaround for orangepi images

Apply release file workaround for OrangePI based images.

Signed-off-by: Stephan Wendel <[email protected]>
miklschmidt pushed a commit to Rat-OS/RatOS that referenced this pull request Feb 25, 2024
Since we applied PR mainsail-crew#241 and mainsail-crew#242,
this function always doesnt give the right value,
which leads to unwanted behaviour in enabling SPI during build.

As we no longer rename the release file,
we have to use its original location in '/etc/armbian-release'
( Or '/etc/orangepi-release' if Opi Image is used )

Signed-off-by: Stephan Wendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants