-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to build because of klipper.service "klippy" alias which might be unnecessary. #245
Comments
Could you provide the full log/output/screenshot of this section? I am wondering because we couldnt build Images if that where the case. This entry exists since ages... What customization of your fork did you do? How do you build the Image? Docker? Git Runner? Native? Regards Kwad |
Well, I tried to look what is the reason for that in your repo and saw you are trying to develop for the Zero3. How about some contributions to MainsailOS and possibly https://github.com/mainsail-crew/armbian-builds ? Maybe we could enhance the current list if builds are valid and well tested? I dont own this SBC but as long you do and do all test, there might be possibilities... @meteyou pinging you for reason :P |
Seems the used alias, which is uneccessary at all, leads to a failing build in some configurations. This should fix mainsail-crew#245 Signed-off-by: Stephan Wendel <[email protected]>
While I'd love to have this board officially supported this might be stunned by the fact that there is no official armbian support too. There are a few differences between this and the Zero 2 that are currently not mainlined, though I do expect them to be within the next 6 months or so. When that happens it's likely we'll see official armbian too. Right now I'm building it through the official build process they provide here https://github.com/orangepi-xunlong/orangepi-build which happens to be some sort of fork of armbian so it works out in the end though it doesn't make me particularly happy. There's also the fact that the 1.5GB version has a quirk effectively requiring a whole build just for it, when in reality only a few kbytes differ between the images (that being the bootloader). |
Well, We use in our "armbian" build chain also the orangepi config because we need that workaround for the Zero 2. Therefore, our buildchain builds a "sunxi" variant maintained by orangepi. See https://github.com/mainsail-crew/armbian-builds/tree/master/configs-orangepi. So, if there is interesst to extend it, please let us know. I would be happy to see contribution like that. |
Sure, any explanation on how your build system works? For example, both u-boot and kernel must be pulled manually for the orangepi build system, yet I wasn't able to find that in the workflows. |
orangepi has a config for it in the "next" branch (all new boards are only in this branch): https://github.com/orangepi-xunlong/orangepi-build/blob/next/external/config/boards/orangepizero3.conf i added it to our Armbian workflow: mainsail-crew/armbian-builds#37 and here you can test the build: https://github.com/mainsail-crew/armbian-builds/actions/runs/6603359688 Pls test the bullseye and bookworm image and give me a short feedback. if they work, i will merge it and they are available in the releases. |
Are these for the 1/2/4G version or the 1.5G? I only own the 1.5G version and it needs separate builds due to different u-boot. |
There is no hint or something about different versions. Have you tested the image yet? |
Please see the following: The 1.5GB version carries a different u-boot. Builds for 1/2/4GB fail to boot on the 1.5GB version. I don't currently have the board on hand but will test when I do soon. But please be aware of the differences. |
Seems the used alias, which is uneccessary at all, leads to a failing build in some configurations. This should fix #245 Signed-off-by: Stephan Wendel <[email protected]>
Even a fix is merged already, lets keep this Issue open for discussion about Zero3 Images. |
As expected the images fail to boot. U-boot shows them trying to initialize 15 Exabytes of RAM. This is on the 1.5GB version of the Orangepi Zero3.
|
Thx for the feedback. I will double-check, how to build this image. |
ok. i double-checked the code and the option MEM_TYPE should work here. i cannot use hit option in the CUI, but i tested a build with it. it runs without any issue until now. pls test it, when it is finished: https://github.com/mainsail-crew/armbian-builds/actions/runs/6631552667?pr=37 |
The 1500mb images both boot successfully and connect to the internet. |
thx for the feedback. then i would merge it to master, that you can use the release images. do you have another question to this topic? |
Nope, thanks! Glad to have this board supported :) |
do you want to add support to mainsailOS? this PR will only create a weekly armbian build. nothing more... |
Support for this would be identical to the orangepi zero2 config. We just need 2 configs for the 1500mb and others builds. |
If iz is that easy, will do changes during this week. Does the overlay, to use SPI on GPIOS work the same as Opi Zero2 ? |
Here are the optional overlays present: orangepi@orangepizero3:/boot/dtb/allwinner/overlay$ ls -lah
total 128K
drwxr-xr-x 2 root root 4.0K Oct 26 18:07 .
drwxr-xr-x 3 root root 4.0K Oct 26 18:07 ..
-rw-r--r-- 1 root root 321 Oct 26 18:03 sun50i-h616-disable-leds.dtbo
-rw-r--r-- 1 root root 228 Oct 26 18:03 sun50i-h616-disable-uart0.dtbo
-rwxr-xr-x 1 root root 4.2K Oct 26 18:03 sun50i-h616-fixup.scr
-rw-r--r-- 1 root root 222 Oct 26 18:03 sun50i-h616-gpu.dtbo
-rw-r--r-- 1 root root 339 Oct 26 18:03 sun50i-h616-ir.dtbo
-rw-r--r-- 1 root root 614 Oct 26 18:03 sun50i-h616-ph-i2c1.dtbo
-rw-r--r-- 1 root root 452 Oct 26 18:03 sun50i-h616-ph-i2c2.dtbo
-rw-r--r-- 1 root root 452 Oct 26 18:03 sun50i-h616-ph-i2c3.dtbo
-rw-r--r-- 1 root root 452 Oct 26 18:03 sun50i-h616-ph-i2c4.dtbo
-rw-r--r-- 1 root root 222 Oct 26 18:03 sun50i-h616-ph-pwm12.dtbo
-rw-r--r-- 1 root root 344 Oct 26 18:03 sun50i-h616-ph-pwm34.dtbo
-rw-r--r-- 1 root root 462 Oct 26 18:03 sun50i-h616-ph-uart2.dtbo
-rw-r--r-- 1 root root 462 Oct 26 18:03 sun50i-h616-ph-uart5.dtbo
-rw-r--r-- 1 root root 712 Oct 26 18:03 sun50i-h616-pi-i2c0.dtbo
-rw-r--r-- 1 root root 344 Oct 26 18:03 sun50i-h616-pi-i2c1.dtbo
-rw-r--r-- 1 root root 564 Oct 26 18:03 sun50i-h616-pi-i2c2.dtbo
-rw-r--r-- 1 root root 439 Oct 26 18:03 sun50i-h616-pi-pwm1.dtbo
-rw-r--r-- 1 root root 439 Oct 26 18:03 sun50i-h616-pi-pwm2.dtbo
-rw-r--r-- 1 root root 439 Oct 26 18:03 sun50i-h616-pi-pwm3.dtbo
-rw-r--r-- 1 root root 439 Oct 26 18:03 sun50i-h616-pi-pwm4.dtbo
-rw-r--r-- 1 root root 462 Oct 26 18:03 sun50i-h616-pi-uart2.dtbo
-rw-r--r-- 1 root root 462 Oct 26 18:03 sun50i-h616-pi-uart3.dtbo
-rw-r--r-- 1 root root 462 Oct 26 18:03 sun50i-h616-pi-uart4.dtbo
-rw-r--r-- 1 root root 619 Oct 26 18:03 sun50i-h616-spi0-spidev.dtbo
-rw-r--r-- 1 root root 871 Oct 26 18:03 sun50i-h616-spi1-cs0-cs1-spidev.dtbo
-rw-r--r-- 1 root root 706 Oct 26 18:03 sun50i-h616-spi1-cs0-spidev.dtbo
-rw-r--r-- 1 root root 706 Oct 26 18:03 sun50i-h616-spi1-cs1-spidev.dtbo
-rw-r--r-- 1 root root 608 Oct 26 18:03 sun50i-h616-usb0-host.dtbo
-rw-r--r-- 1 root root 285 Oct 26 18:03 sun50i-h616-zero2w-disable-led.dtbo from |
Seems the used alias, which is uneccessary at all, leads to a failing build in some configurations. This should fix mainsail-crew#245 Signed-off-by: Stephan Wendel <[email protected]>
I just tested. Uboot log:
|
Sorry, I didn't read source correctly. |
Exactly this one is deactivated to apply Network configuration as described in https://docs-os.mainsail.xyz/faq/change-wifi-credentials |
For reference:
|
Btw. would you mind joining our discord ? discord.gg/mainsail. We could open a thread there for realtime discussion if you are interessted in that. |
Seems the used alias, which is uneccessary at all, leads to a failing build in some configurations. This should fix mainsail-crew#245 Signed-off-by: Stephan Wendel <[email protected]>
What happened
During build it fails to enable the klipper service as the klippy alias seems to already be taken apparently. I looked around and there doesn't actually seem to be anything using this alias. Removing the alias builds successfully and klipper (and klippy) start correctly.
https://github.com/mainsail-crew/MainsailOS/blob/develop/src/modules/klipper/filesystem/root/etc/systemd/system/klipper.service#L9
There might be a reason for this to exist potentially, hence why I am reporting it as a bug rather than a PR to remove it, as I'm not confident this should be removed. If I install klipper with KIAUH on the same device, it appears to create a service file without the alias.
What did you expect to happen
Unrelated
How to reproduce
Unrelated
Additional information
No response
The text was updated successfully, but these errors were encountered: