Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.x does not work with Embroider #769

Closed
mydea opened this issue Jul 23, 2021 · 1 comment
Closed

6.x does not work with Embroider #769

mydea opened this issue Jul 23, 2021 · 1 comment

Comments

@mydea
Copy link
Contributor

mydea commented Jul 23, 2021 •
edited
Loading

Just leaving this here as a reference issue if somebody else runs into this - since 6.x dropped the bind-data-test-attributes util, embroider will break as it has a custom adapter which references this. I made a PR fixing this in embroider:

embroider-build/embroider#904
@Turbo87
Copy link
Collaborator

Turbo87 commented Aug 29, 2021

looks like embroider-build/embroider#904 was merged so I'll close this issue :)

@Turbo87 Turbo87 closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Turbo87 @mydea