Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: consider no longer re-exporting anything in app #2810

Open
runspired opened this issue Aug 8, 2024 · 1 comment
Open

idea: consider no longer re-exporting anything in app #2810

runspired opened this issue Aug 8, 2024 · 1 comment

Comments

@runspired
Copy link
Contributor

Since it is fairly common to extend the session service within an app, the re-export is both unneeded and in many build setups results in indeterminant service resolution during build when the app uses session.ts instead of session.js

@BobrImperator
Copy link
Collaborator

Great timing for the suggestion as I'm planning to make some breaking changes.

AFAIK that's what ember-data also does in newer versions - where you're required to import it yourself, but I'd like to ask.

What about initializers?
Would you expect users to import them themselves?
Or is it a time to come up with an implementation that doesn't rely on them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants